From: Junio C Hamano <email@example.com> To: Andreas Ericsson <firstname.lastname@example.org> Cc: email@example.com Subject: Re: [PATCH] git-diff: Introduce --index and deprecate --cached. Date: Fri, 08 Dec 2006 18:29:02 -0800 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> (Junio C. Hamano's message of "Fri, 08 Dec 2006 18:24:31 -0800") Junio C Hamano <firstname.lastname@example.org> writes: > Although I've applied this long time ago (in git timescale > anyway), this patch and the above rationale is wrong. > > 'diff --cached' is more in line with how 'apply --cached' works, > not how 'apply --index' works. Side note. I do not think --index and --cached are a good pair of words to express the different semantics (the former works on the working tree through the index, the latter works only on the cached data and not on the working tree). I was only pointing out that making 'diff --index' a synonym to 'diff --cached' closes the door for the possibility to have these two semantics that are consistently spelled (well, maybe "confusingly spelled", but still consistently) between diff and apply.
prev parent reply index Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2006-11-30 11:43 Andreas Ericsson 2006-12-09 2:24 ` Junio C Hamano 2006-12-09 2:29 ` Junio C Hamano [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Mailing List Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/git/0 git/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 git git/ https://lore.kernel.org/git \ email@example.com public-inbox-index git Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git