archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <>
To: Andreas Ericsson <>
Subject: Re: [PATCH] git-diff: Introduce --index and deprecate --cached.
Date: Fri, 08 Dec 2006 18:29:02 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Junio C. Hamano's message of "Fri, 08 Dec 2006 18:24:31 -0800")

Junio C Hamano <> writes:

> Although I've applied this long time ago (in git timescale
> anyway), this patch and the above rationale is wrong.
> 'diff --cached' is more in line with how 'apply --cached' works,
> not how 'apply --index' works.

Side note.  I do not think --index and --cached are a good pair
of words to express the different semantics (the former works on
the working tree through the index, the latter works only on the
cached data and not on the working tree).  I was only pointing
out that making 'diff --index' a synonym to 'diff --cached'
closes the door for the possibility to have these two semantics
that are consistently spelled (well, maybe "confusingly
spelled", but still consistently) between diff and apply.

  reply	other threads:[~2006-12-09  2:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-30 11:43 [PATCH] git-diff: Introduce --index and deprecate --cached Andreas Ericsson
2006-12-09  2:24 ` Junio C Hamano
2006-12-09  2:29   ` Junio C Hamano [this message]
2020-11-10  7:32 Jake Steward
2021-09-12 21:39 nu ja
2022-06-15  7:58 Ali Almrhbi
2022-12-17 21:48 Bob Swift

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).