From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2012, #01; Sun, 3)
Date: Mon, 11 Jun 2012 07:54:28 -0700 [thread overview]
Message-ID: <7v7gvdaogr.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAMP44s2US+PoxfboZSML84GEvUwiHV4eQBOQSp6zhruT8xrKdg@mail.gmail.com> (Felipe Contreras's message of "Sun, 10 Jun 2012 17:09:22 +0200")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> You say I'm being irresponsible, I say you are being preoccupied by a
> theoretical problem that will not occur, and would not cause any
> problems if it does.
See how the two implementations are different and think what happens
when a user dot sources these two scripts in different order. Callers
of __gitdir in one expects it to pay attention to GIT_DIR, callers in
the other don't, but you can't have both at the same time in the
same shell, can you?
It is not theoretical, as you yourself already made it happen.
Get over it.
next prev parent reply other threads:[~2012-06-11 14:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 0:23 What's cooking in git.git (Jun 2012, #01; Sun, 3) Junio C Hamano
2012-06-06 12:22 ` Felipe Contreras
2012-06-06 17:58 ` Junio C Hamano
2012-06-06 18:17 ` Felipe Contreras
2012-06-10 7:26 ` Junio C Hamano
2012-06-10 15:09 ` Felipe Contreras
2012-06-11 14:54 ` Junio C Hamano [this message]
2012-06-13 14:55 ` Felipe Contreras
2012-06-13 17:19 ` Junio C Hamano
2012-06-13 18:04 ` Felipe Contreras
2012-06-10 17:39 ` René Scharfe
2012-06-11 10:27 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7gvdaogr.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).