git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Sverre Hvammen Johansen" <hvammen@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] Additional fast forward strategies.
Date: Mon, 10 Mar 2008 23:34:27 -0700	[thread overview]
Message-ID: <7v8x0pepl8.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <402c10cd0803102004x7892f01cledfef6f277fba26a@mail.gmail.com> (Sverre Hvammen Johansen's message of "Mon, 10 Mar 2008 19:04:38 -0800")

"Sverre Hvammen Johansen" <hvammen@gmail.com> writes:

>>From 779142c6b22f032c877f550733e1bccc99aca761 Mon Sep 17 00:00:00 2001
> From: Sverre Hvammen Johansen <hvammen@gmail.com>
> Date: Sun, 9 Mar 2008 21:16:03 -0800
> Subject: [PATCH] Additional fast forward strategies.

Ditto..

> New fast forward strategies, common, fork, path, and same
> is introduced.  These new fast forward strategies allows
> additional work flows.

Is it sufficient to say "allows additional work flows" here?  I only see
what they do, and do not see why these are needed/useful anywhere in the
proposed commit log message nor documentation. 

You need to illustrate the motivation after the above three-line paragraph
and before the description of what each of them does below.  "Suppose your
history looks like this, and you and your group's workflow is like this.
Then you would want to only allow these but want to forbid those for such
and such reasons."  Then list what the "FF options" do.  After that, you
can conclude "By using these FF options this way, you can achieve that
control like this..."

Then people might be convinced that "these allow additional work flows".
What you wrote is insufficient, I am afraid.  At least to me.

> +	if test $fast_forward = same
> +	then
> +		for b in "$@"

'in "$@"' is always redundant after "for X".

More seriously, why is the user forced to give more than one "same" thing
to begin with?  The user can give a single thing and be done with it.

  reply	other threads:[~2008-03-11  6:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11  3:04 [RFC/PATCH] Additional fast forward strategies Sverre Hvammen Johansen
2008-03-11  6:34 ` Junio C Hamano [this message]
2008-03-11  9:09 ` Jakub Narebski
2008-03-12  6:03 ` Sverre Hvammen Johansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8x0pepl8.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hvammen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).