From: Junio C Hamano <gitster@pobox.com>
To: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
Cc: Alexander Strasser <eclipse7@gmx.net>,
"git\@vger.kernel.org" <git@vger.kernel.org>,
mj@ucw.cz, Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [eclipse7@gmx.net: [PATCH] diff: Only count lines in show_shortstats()]
Date: Thu, 14 Jun 2012 13:28:16 -0700 [thread overview]
Message-ID: <7vaa05eizj.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4FDA3668.3000900@in.waw.pl> ("Zbigniew =?utf-8?Q?J=C4=99drze?= =?utf-8?Q?jewski-Szmek=22's?= message of "Thu, 14 Jun 2012 21:07:20 +0200")
Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> writes:
> On 06/07/2012 10:29 PM, Junio C Hamano wrote:
> ...
>> Please keep a bugfix patch to only fixes with tests. Style fixes
>> should be done later after dust from more important changes (e.g. a
>> bugfix) settles.
>>
>> Thanks.
>
> Does this need a v2?
>
> Zbyszek
That is a question to be asked with Alex on the To: line, not me, I
would think. I saw "Ah, I see. I will try to do better next time."
in his response to your review, but haven't seen the "next time"
reroll yet.
prev parent reply other threads:[~2012-06-14 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120607122149.GA3070@akuma>
2012-06-07 19:05 ` [eclipse7@gmx.net: [PATCH] diff: Only count lines in show_shortstats()] Zbigniew Jędrzejewski-Szmek
2012-06-07 20:04 ` Alexander Strasser
2012-06-07 20:29 ` Junio C Hamano
2012-06-14 19:07 ` Zbigniew Jędrzejewski-Szmek
2012-06-14 20:28 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vaa05eizj.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=eclipse7@gmx.net \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=mj@ucw.cz \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).