git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "David A. Greene" <dag@cray.com>
Cc: Herman van Rink <rink@initfour.nl>, <greened@obbligato.org>,
	Hilco Wijbenga <hilco.wijbenga@gmail.com>,
	Git Users <git@vger.kernel.org>
Subject: Re: Subtree in Git
Date: Fri, 11 May 2012 13:24:02 -0700	[thread overview]
Message-ID: <7vaa1elb4t.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <nngzk9jvemb.fsf@transit.us.cray.com> (dag@cray.com's message of "Mon, 7 May 2012 16:57:16 -0500")

<dag@cray.com> writes:

> Herman van Rink <rink@initfour.nl> writes:
>
>> As an alternative I've now applied a patch with all changes on a clean
>> master branch.
>> In the commit message I've named all committers from the original history.
>> Would that be acceptable?
>
> Seems ok to me but Junio has the final say.

What we do *not* want to see are merges from commits after the "subtree"
stuff is moved down to "contrib/subtree" into commits before the merge
happened, as that would mean "constant renaming merge" mess in the history
(see http://article.gmane.org/gmane.comp.version-control.git/197689 as
well).

If it is too much trouble to clean up the history, it is OK to leave
"oops, an earlier one was a total mistake but it is too late to rewind the
tree, so here is a fixup" commits.  At the very least, however, it should
be possible to clean up the history to pretend that everything has
happened _after_ the "git-subtree" project transitioned to have its files
under "contrib/subtree" hierarchy in preparation for eventually becoming a
part of the core git, no?  Then the back-merges from your tree to Herman's
will be merging updates to contrib/subtree part into contrib/subtree part,
and "git log contrib/subtree" will give us a readable output.

I thought "subtree" was a tool to make it very easy to let you pretend
that everything happened in the context of containing larger tree when you
wanted to, so I am hoping that is not asking too much (even a subtree
unaware "filter-branch" should be able to do that kind of thing, I would
think).

Thanks.

  reply	other threads:[~2012-05-11 20:24 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-27 18:48 Subtree in Git Hilco Wijbenga
2012-04-27 20:38 ` dag
2012-04-27 21:09   ` Hilco Wijbenga
2012-05-01  8:34   ` Herman van Rink
2012-05-04  2:26     ` greened
2012-05-04 10:08       ` Herman van Rink
2012-05-05  4:25       ` Junio C Hamano
2012-05-07 15:21         ` dag
2012-05-07 19:50         ` Herman van Rink
2012-05-07 21:57           ` dag
2012-05-11 20:24             ` Junio C Hamano [this message]
2012-05-23 15:13             ` dag
2012-06-12  1:30               ` greened
2012-06-13 13:20                 ` Herman van Rink
2012-07-11 16:14                   ` dag
2012-10-20 20:03                     ` Herman van Rink
2012-10-21  6:32                       ` Junio C Hamano
2012-10-21 15:09                         ` Herman van Rink
2012-10-21 19:51                           ` Junio C Hamano
2012-10-21 20:23                             ` Herman van Rink
2012-10-22 14:47                               ` dag
2012-10-22 14:44                             ` dag
2012-10-22 14:41                           ` dag
2012-10-26 13:10                             ` Herman van Rink
2012-10-26 13:58                               ` David Michael Barr
2012-10-26 16:54                                 ` James Nylen
2012-10-29 15:55                                 ` dag
2013-03-01  2:28                                 ` Kindjal
2013-03-01 22:05                                   ` Paul Campbell
2013-03-02 11:21                                     ` David Michael Barr
2013-03-02 17:43                                       ` Paul Campbell
2013-03-04 22:33                                         ` Paul Campbell
2012-10-29 15:53                               ` dag
2012-05-04 22:50   ` Daniel Koester
2012-06-12  1:32     ` greened

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vaa1elb4t.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=dag@cray.com \
    --cc=git@vger.kernel.org \
    --cc=greened@obbligato.org \
    --cc=hilco.wijbenga@gmail.com \
    --cc=rink@initfour.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).