From: Junio C Hamano <gitster@pobox.com>
To: Matthijs Kooijman <matthijs@stdin.nl>
Cc: git@vger.kernel.org
Subject: Re: Lines missing from git diff-tree -p -c output?
Date: Wed, 15 May 2013 12:13:26 -0700 [thread overview]
Message-ID: <7vd2ssawfd.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130515181734.GT25742@login.drsnuggles.stderr.nl> (Matthijs Kooijman's message of "Wed, 15 May 2013 20:17:34 +0200")
Matthijs Kooijman <matthijs@stdin.nl> writes:
>> Could you explain why you think it hides the real problem, and what
>> kind of future enhancement may break it?
> I think the differences is mostly in the locality of the fix. In my
> proposed patch, the no_pre_delete flag is never set on an interesting
> line because it is checked in the line before it. In your patch, it
> never happens because the control flow guarantees the "context" lines
> before each change must be uninteresting.
>
> The net effect is of course identical, but I'm arguing that depending on
> the control flow and some code a doze lines down is easier to break than
> depending on a previous line.
Yeah, that sounds like a reasonable reasoning.
prev parent reply other threads:[~2013-05-15 19:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 14:35 Lines missing from git diff-tree -p -c output? Matthijs Kooijman
2013-05-15 15:46 ` Matthijs Kooijman
2013-05-15 17:17 ` Junio C Hamano
2013-05-15 17:33 ` Matthijs Kooijman
2013-05-15 17:42 ` [PATCH] combine-diff.c: Fix output when changes are exactly 3 lines apart Matthijs Kooijman
2013-05-15 17:48 ` Lines missing from git diff-tree -p -c output? Junio C Hamano
2013-05-15 18:17 ` Matthijs Kooijman
2013-05-15 19:13 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd2ssawfd.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=matthijs@stdin.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).