From: Junio C Hamano <gitster@pobox.com>
To: "Carlos Martín Nieto" <cmn@elego.de>
Cc: git@vger.kernel.org, Yann Dirson <dirson@bertin.fr>
Subject: Re: [PATCH 1/2] Documentation: --no-walk is no-op if range is specified
Date: Fri, 15 Jun 2012 10:37:53 -0700 [thread overview]
Message-ID: <7vk3z8bhn2.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1339770796-542-1-git-send-email-cmn@elego.de> ("Carlos =?utf-8?Q?Mart=C3=ADn?= Nieto"'s message of "Fri, 15 Jun 2012 16:33:15 +0200")
Carlos Martín Nieto <cmn@elego.de> writes:
> The existing description can be misleading and cause the reader to
> think that --no-walk will do something if they specify a range in the
> command line instead of a set of revs.
>
> Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
> ---
> Documentation/rev-list-options.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt
> index 1ae3c89..84e34b1 100644
> --- a/Documentation/rev-list-options.txt
> +++ b/Documentation/rev-list-options.txt
> @@ -622,6 +622,7 @@ These options are mostly targeted for packing of git repositories.
> --no-walk::
>
> Only show the given revs, but do not traverse their ancestors.
> + This has no effect if a range is specified.
>
> --do-walk::
This is correct as a description of the current behaviour, but I
have to wonder if we should error out when the user explicitly
(i.e. the implicit uses of --no-walk by "show" and "cherry-pick"
need to be treated differently) gives --no-walk and a negative
commit (either by A..B range, or a separate ^A).
Would that break a valid script, and if not, how involved would such
a fix be?
next prev parent reply other threads:[~2012-06-15 17:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 9:44 [BUG] cherry-pick ignores some arguments Yann Dirson
2012-06-14 16:29 ` Carlos Martín Nieto
2012-06-15 7:14 ` Yann Dirson
2012-06-15 13:12 ` Carlos Martín Nieto
2012-06-15 14:33 ` [PATCH 1/2] Documentation: --no-walk is no-op if range is specified Carlos Martín Nieto
2012-06-15 14:33 ` [PATCH 2/2] git-cherry-pick.txt: make clearer when revision walking gets activated Carlos Martín Nieto
2012-06-15 17:52 ` Junio C Hamano
2012-06-15 17:37 ` Junio C Hamano [this message]
2012-06-15 14:39 ` [BUG] cherry-pick ignores some arguments Carlos Martín Nieto
2012-06-15 15:06 ` Junio C Hamano
2012-06-15 15:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk3z8bhn2.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=cmn@elego.de \
--cc=dirson@bertin.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).