From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Avery Pennarun <apenwarr@gmail.com>,
SungHyun Nam <goweol@gmail.com>,
git@vger.kernel.org
Subject: Re: 'git add' regression in git-1.7?
Date: Sun, 14 Mar 2010 19:02:53 -0700 [thread overview]
Message-ID: <7vljdul4tu.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100314204459.GA31564@coredump.intra.peff.net> (Jeff King's message of "Sun\, 14 Mar 2010 16\:44\:59 -0400")
Jeff King <peff@peff.net> writes:
> In which case, I think we perhaps actively _don't_ want to complain
> about ignored globs at all.
> ...
> So if that reasoning is sound, I think we want to just leave git-add's
> behavior as it is currently (with my patch from earlier in this thread
> applied, of course). You get different error messages for "git add *.c"
> and "git add '*.c'", but that is only natural. You also get different
> _behavior_, and that is intentional.
Yeah, I think that makes sense.
prev parent reply other threads:[~2010-03-15 2:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 4:30 'git add' regression in git-1.7? SungHyun Nam
2010-02-19 4:42 ` Avery Pennarun
2010-02-19 5:04 ` SungHyun Nam
2010-02-19 5:15 ` Avery Pennarun
2010-02-19 5:34 ` Jeff King
2010-02-19 6:02 ` Jeff King
2010-02-19 8:24 ` Jeff King
2010-03-01 2:00 ` Junio C Hamano
2010-03-01 3:25 ` [PATCH] add: fail "git add ignored-dir/file" without -f Junio C Hamano
2010-03-01 8:26 ` [PATCH 1/3] t0050: mark non-working test as such Junio C Hamano
2010-03-09 22:37 ` 'git add' regression in git-1.7? Jeff King
2010-03-09 23:09 ` Jeff King
2010-03-10 7:06 ` Junio C Hamano
2010-03-11 7:15 ` Jeff King
2010-03-14 6:34 ` Junio C Hamano
2010-03-14 20:44 ` Jeff King
2010-03-15 2:02 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vljdul4tu.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=goweol@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).