From: Junio C Hamano <firstname.lastname@example.org> To: Robert Fitzsimons <email@example.com> Cc: Alex Riesen <firstname.lastname@example.org>, email@example.com, Kai Ruemmler <firstname.lastname@example.org> Cc: email@example.com Subject: Re: [PATCH] Try URI quoting for embedded TAB and LF in pathnames Date: Sat, 08 Oct 2005 13:19:10 -0700 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> (Junio C. Hamano's message of "Sat, 08 Oct 2005 11:30:21 -0700") Junio C Hamano <firstname.lastname@example.org> writes: > Robert Fitzsimons <email@example.com> writes: > >> '\t' becomes %09 >> '\n' becomes %10 >> '%' becomes %25 >> >> Signed-off-by: Robert Fitzsimons <firstname.lastname@example.org> > > This would break existing setup where people *has* per-cent > letter in their pathname -- which I think is worse than the > backslash proposal. Having said that, I think something along the lines of backslash or URI encoding is the cleanest way to go in the long run, with one condition: diffs generated with git-diff should be applicable with 'GNU patch', especially if there is no funnies like renames and the recipient does not mind losing mode information. Although 'GNU patch' has --quoting-style flag, it seems to be used only on its output side (i.e. reporting which file it is patching, etc.). If we can sell changes to teach the filename encoding convention to its util.c::fetchname() upstream, we could tell people that 'diff --git' can be applied with newer 'GNU patch' when the patch is about a file whose name contains '%' character (which is not that unusual, compared to TAB and LF). While we are selling those changes to 'GNU patch', we might be even be able to sell the other extended 'diff --git' metainformation support. The same filename quoting rules change should probably be sold to 'GNU diff' as well, so that plain diff can natively quote funny characters in its output without forcing us to fake it by using the -L flag. If all of the above is what we aim for, I would say that is a good direction to go in the longer term. The double-slash hack was just to avoid all these hassles of having to muck with other people's tools.
next prev parent reply index Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2005-10-07 19:35 [RFC] " Junio C Hamano 2005-10-07 23:29 ` Alex Riesen 2005-10-07 23:44 ` Junio C Hamano 2005-10-08 6:45 ` Alex Riesen 2005-10-08 9:10 ` Junio C Hamano 2005-10-08 13:30 ` [PATCH] Try URI quoting for " Robert Fitzsimons 2005-10-08 18:30 ` Junio C Hamano 2005-10-08 20:19 ` Junio C Hamano [this message] 2005-10-11 6:20 ` Paul Eggert 2005-10-11 7:37 ` Junio C Hamano 2005-10-11 15:17 ` Linus Torvalds 2005-10-11 18:03 ` Paul Eggert 2005-10-11 18:37 ` Linus Torvalds 2005-10-11 19:42 ` Paul Eggert 2005-10-11 20:56 ` Linus Torvalds 2005-10-12 6:51 ` Paul Eggert 2005-10-12 14:59 ` Linus Torvalds 2005-10-12 19:07 ` Daniel Barkalow 2005-10-12 19:52 ` Linus Torvalds 2005-10-12 20:21 ` H. Peter Anvin [not found] ` <email@example.com> 2005-10-12 21:02 ` Junio C Hamano 2005-10-12 21:05 ` Linus Torvalds 2005-10-12 21:09 ` H. Peter Anvin 2005-10-12 21:15 ` Johannes Schindelin 2005-10-12 21:33 ` Junio C Hamano 2005-10-14 0:57 ` Paul Eggert 2005-10-14 5:43 ` Linus Torvalds 2005-10-12 21:24 ` Linus Torvalds 2005-10-14 0:16 ` Paul Eggert 2005-10-14 5:20 ` Linus Torvalds 2005-10-14 17:18 ` H. Peter Anvin 2005-10-14 6:59 ` Junio C Hamano 2005-10-09 10:42 ` Junio C Hamano
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Mailing List Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/git/0 git/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 git git/ https://lore.kernel.org/git \ firstname.lastname@example.org public-inbox-index git Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git