From: Junio C Hamano <gitster@pobox.com>
To: Brad King <brad.king@kitware.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation/commit-tree: mention -S option
Date: Mon, 25 Mar 2013 13:39:57 -0700 [thread overview]
Message-ID: <7vy5dbw6w2.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <14b024f9ee5c6319a0ff1f700f52d29b2464764f.1364240065.git.brad.king@kitware.com> (Brad King's message of "Mon, 25 Mar 2013 15:39:00 -0400")
Brad King <brad.king@kitware.com> writes:
> Commit ba3c69a9 (commit: teach --gpg-sign option, 2011-10-05) added the
> -S option and documented it in the command usage. Then commit 098bbdc3
> (Add -S, --gpg-sign option to manpage of "git commit", 2012-10-21)
> documented it in the porcelain manpage. Use wording from the porcelain
> to document the option in the plumbing manpage too.
> ---
This does not seem to use the same wording, though.
git commit -S
will pick up the signing key by calling get_signing_key() the same
way "git tag -s" would, iow, <keyid> part is optional.
> Documentation/git-commit-tree.txt | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/git-commit-tree.txt b/Documentation/git-commit-tree.txt
> index 86ef56e..62f7b53 100644
> --- a/Documentation/git-commit-tree.txt
> +++ b/Documentation/git-commit-tree.txt
> @@ -10,7 +10,9 @@ SYNOPSIS
> --------
> [verse]
> 'git commit-tree' <tree> [(-p <parent>)...] < changelog
> -'git commit-tree' [(-p <parent>)...] [(-m <message>)...] [(-F <file>)...] <tree>
> +'git commit-tree' [(-p <parent>)...] [-S<keyid>] [(-m <message>)...]
> + [(-F <file>)...] <tree>
> +
>
> DESCRIPTION
> -----------
> @@ -52,6 +54,9 @@ OPTIONS
> Read the commit log message from the given file. Use `-` to read
> from the standard input.
>
> +-S<keyid>::
> + GPG-sign commit.
> +
>
> Commit Information
> ------------------
next prev parent reply other threads:[~2013-03-25 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 19:39 [PATCH] Documentation/commit-tree: mention -S option Brad King
2013-03-25 20:06 ` Junio C Hamano
2013-03-25 20:15 ` Brad King
2013-03-25 20:39 ` Junio C Hamano [this message]
2013-03-25 21:00 ` [PATCH v2] commit-tree: document -S option consistently Brad King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy5dbw6w2.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=brad.king@kitware.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).