[PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out

[PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out

[Christian Couder]

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 help.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

	This was suggested by Xavier Maillard.

diff --git a/help.c b/help.c
index 5da8c9c..ecaca77 100644
--- a/help.c
+++ b/help.c
@@ -139,7 +139,7 @@ static int add_man_viewer(const char *value)
 	else if (!strcasecmp(value, "konqueror"))
 		do_add_man_viewer(exec_man_konqueror);
 	else
-		return error("'%s': unsupported man viewer.", value);
+		warning("'%s': unsupported man viewer.", value);
 
 	return 0;
 }
-- 
1.5.4.3.395.g492b.dirty

Re: [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out

[Junio C Hamano]

Christian Couder <chriscool@tuxfamily.org> writes:

> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  help.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> 	This was suggested by Xavier Maillard.
>
> diff --git a/help.c b/help.c
> index 5da8c9c..ecaca77 100644
> --- a/help.c
> +++ b/help.c
> @@ -139,7 +139,7 @@ static int add_man_viewer(const char *value)
>  	else if (!strcasecmp(value, "konqueror"))
>  		do_add_man_viewer(exec_man_konqueror);
>  	else
> -		return error("'%s': unsupported man viewer.", value);
> +		warning("'%s': unsupported man viewer.", value);
>  
>  	return 0;
>  }

While I'd agree this is a good change, the author should justify it in the
commit log message.  I ask list regulars like you to set a good example
for others.

	When a document viewer that is unknown to the current version of
	git is specified in the .git/config file, instead of erroring out
	the process completely, just issue a warning.  It might be that
	the user usually is using a newer git that supports it (and the
	configuration is written for that version) but is temporarily
	using an older git that does not know the viewer.

Re: [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out

[Xavier Maillard]

   Signed-off-by: Christian Couder <chriscool@tuxfamily.org>

It's perfect. Thank you Christian.

Tested-by: Xavier Maillard <xma@gnu.org>

	Xavier
-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org