archive mirror
 help / color / mirror / Atom feed
From: "William Baker via GitGitGadget" <>
	Junio C Hamano <>,
	William Baker <>
Subject: [PATCH 1/1] t7519-status-fsmonitor: improve comments
Date: Wed, 16 Oct 2019 19:35:47 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: William Baker <>

The comments for the staging/unstaging test did not accurately
describe the scenario being tested.  It is not essential that
the test files being staged/unstaged appear at the end of the
index.  All that is required is that the test files are not
flagged with CE_FSMONITOR_VALID and have a position in the
index greater than the number of entries in the index after

The comment for this test has been updated to be more
accurate with respect to the scenario that's being tested.

Signed-off-by: William Baker <>
 t/ | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/t/ b/t/
index d8df990972..997d5fb349 100755
--- a/t/
+++ b/t/
@@ -354,9 +354,11 @@ test_expect_success 'discard_index() also discards fsmonitor info' '
 	test_cmp expect actual
-# Test staging/unstaging files that appear at the end of the index.  Test
-# file names begin with 'z' so that they are sorted to the end of the index.
-test_expect_success 'status succeeds after staging/unstaging ' '
+# Test unstaging entries that:
+#  - Are not flagged with CE_FSMONITOR_VALID
+#  - Have a position in the index >= the number of entries present in the index
+#    after unstaging.
+test_expect_success 'status succeeds after staging/unstaging' '
 	test_create_repo fsmonitor-stage-unstage &&
 		cd fsmonitor-stage-unstage &&

  reply	other threads:[~2019-10-16 19:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 19:35 [PATCH 0/1] t7519-status-fsmonitor: improve comments William Baker via GitGitGadget
2019-10-16 19:35 ` William Baker via GitGitGadget [this message]
2019-10-29 20:07   ` [PATCH 1/1] " William Baker
2019-10-30  2:52     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).