git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junichi Uekawa <dancer@netfort.gr.jp>
To: Petr Baudis <pasky@suse.cz>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] cogito: use locale date_fmt in obtaining default date format
Date: Thu, 13 Oct 2005 00:26:44 +0900	[thread overview]
Message-ID: <8764s2hi2z.dancerj%dancer@netfort.gr.jp> (raw)
In-Reply-To: <878xwyomth.dancerj%dancer@netfort.gr.jp>

Hi,

>  	if [ "$has_gnudate" ]; then
>  		LANG=C $has_gnudate -ud "1970-01-01 UTC + $secs sec" "$format"
>  	else

Hmm... I just noticed that you're setting LANG=C here;
which is not enough since LC_ALL will override the value.

I'm not quite sure of the original intention;
I've checked the users


cg-log:
	For local display; it should be okay to show the date in 
	localized format.

cg-mkpatch:
	It might be intrusive to have a localized date in a patch;
	so having a localized output of showdate is mostly undesirable,
	but it will depend on the project you work on.
	(The user can always unset locale)


regards,
	junichi

      reply	other threads:[~2005-10-12 15:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-12 14:02 [PATCH] cogito: use locale date_fmt in obtaining default date format Junichi Uekawa
2005-10-12 15:26 ` Junichi Uekawa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8764s2hi2z.dancerj%dancer@netfort.gr.jp \
    --to=dancer@netfort.gr.jp \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).