From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Han-Wen Nienhuys <hanwen@google.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@s-opensource.com>
Subject: Re: [PATCH 1/5] "lib-diff" tests: make "README" and "COPYING" test data smaller
Date: Mon, 04 Oct 2021 19:59:12 +0200 [thread overview]
Message-ID: <877desmzzt.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <CAFQ2z_NwrpMuYmtB1caokup9SCr=od97ONG86c4PWmfEJ5vZCg@mail.gmail.com>
On Mon, Oct 04 2021, Han-Wen Nienhuys wrote:
> On Sat, Oct 2, 2021 at 11:19 AM Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
>>
>> Follow-up the change in 459b8d22e54 (tests: do not borrow from COPYING
>> and README from the real source, 2015-02-15) by not shipping a full
>> copy of older versions of the top-level "COPYING" and "README" files.
>>
>> The tests that use them just need the small blurb at the top of
>> "COPYING" as test data, or mock data that's dissimilar. Let's provide
>> that with a "COPYING_test_data" function instead.
>
> I had to read this patch a couple of times before I understood what
> was going on.
>
> Your change is a definite improvement, but if the actual contents
> don't matter that much, maybe something like "lorum ipsum" would be
> even better.
The actual contents do matter to the existing tests, which e.g. in
t4003-diff-rename-1.sh munge the COPYING file and then assert the exact
resulting diff output.
Those tests could all be rewritten to use some new better-known test
content, but I figured that wasn't worth it in this case, as opposed to
just providing them with the data from the opening paragraphs the tests
are interested in / faking up a new "README".
next prev parent reply other threads:[~2021-10-04 18:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 9:19 [PATCH 0/5] COPYING: modernize, steal boilerplate from linux.git Ævar Arnfjörð Bjarmason
2021-10-02 9:19 ` [PATCH 1/5] "lib-diff" tests: make "README" and "COPYING" test data smaller Ævar Arnfjörð Bjarmason
2021-10-04 16:46 ` Han-Wen Nienhuys
2021-10-04 17:59 ` Ævar Arnfjörð Bjarmason [this message]
2021-10-02 9:19 ` [PATCH 2/5] tests: stop using top-level "README" and "COPYING" files Ævar Arnfjörð Bjarmason
2021-10-02 9:19 ` [PATCH 3/5] COPYING: remove mention of GPLv3, clarify sub-project COPYING Ævar Arnfjörð Bjarmason
2021-10-04 6:21 ` Junio C Hamano
2021-10-02 9:19 ` [PATCH 4/5] COPYING: move GPL text to a "GPL-2.0" file Ævar Arnfjörð Bjarmason
2021-10-02 9:19 ` [PATCH 5/5] GPL-2.0: update to byte-for-byte match the FSF's version Ævar Arnfjörð Bjarmason
2021-10-04 17:28 ` [PATCH 0/5] COPYING: modernize, steal boilerplate from linux.git Han-Wen Nienhuys
2021-10-05 17:01 ` [PATCH v2 " Ævar Arnfjörð Bjarmason
2021-10-05 17:01 ` [PATCH v2 1/5] "lib-diff" tests: make "README" and "COPYING" test data smaller Ævar Arnfjörð Bjarmason
2021-10-05 17:01 ` [PATCH v2 2/5] tests: stop using top-level "README" and "COPYING" files Ævar Arnfjörð Bjarmason
2021-10-05 17:01 ` [PATCH v2 3/5] COPYING: remove mention of GPLv3, clarify sub-project COPYING Ævar Arnfjörð Bjarmason
2021-10-05 17:01 ` [PATCH v2 4/5] COPYING: move GPL text to a "GPL-2.0" file Ævar Arnfjörð Bjarmason
2021-10-05 17:01 ` [PATCH v2 5/5] GPL-2.0: update to byte-for-byte match the FSF's version Ævar Arnfjörð Bjarmason
2021-10-15 9:30 ` [PATCH v3 0/2] tests: stop relying on top-level COPYING and README Ævar Arnfjörð Bjarmason
2021-10-15 9:30 ` [PATCH v3 1/2] "lib-diff" tests: make "README" and "COPYING" test data smaller Ævar Arnfjörð Bjarmason
2021-10-15 16:36 ` Junio C Hamano
2021-10-15 9:30 ` [PATCH v3 2/2] tests: stop using top-level "README" and "COPYING" files Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877desmzzt.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanwen@google.com \
--cc=mchehab@s-opensource.com \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).