From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "Osipov\, Michael" <michael.osipov@siemens.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] sha1dc: update from upstream
Date: Wed, 15 May 2019 13:48:27 +0200 [thread overview]
Message-ID: <87a7fovsz8.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <09f64da1-b8aa-3cd7-89d7-475b8722e176@siemens.com>
On Tue, May 14 2019, Osipov, Michael wrote:
> Hi,
>
> Am 2019-05-14 um 00:17 schrieb Ævar Arnfjörð Bjarmason:
>> Update sha1dc from the latest version by the upstream
>> maintainer[1]. See 07a20f569b ("Makefile: fix unaligned loads in
>> sha1dc with UBSan", 2019-03-12) for the last update.
>>
>> This fixes an issue where HP-UX IA64 was wrongly detected as a
>> Little-endian instead of a Big-endian system, see [2] and [3].
>>
>> 1. https://github.com/cr-marcstevens/sha1collisiondetection/commit/855827c583bc30645ba427885caa40c5b81764d2
>> 2. https://public-inbox.org/git/603989bd-f86d-c61d-c6f5-fb6748a65ba9@siemens.com/
>> 3. https://github.com/cr-marcstevens/sha1collisiondetection/pull/50
>>
>> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>> ---
>>
>> n Thu, May 09 2019, Osipov, Michael wrote:
>>
>>> Hey there,
>>>
>>> Am 2019-05-09 um 09:32 schrieb Ævar Arnfjörð Bjarmason:
>>>>
>>>> On Wed, May 08 2019, Osipov, Michael wrote:
>>>>
>>>>> Hi folks,
>>>>
>>>> Hi see Documentation/SubmittingPatches for how to submit patches inline
>>>> instead of as attachments.
>>>
>>> Do you want me to resend the configure.ac change as per wiki article?
>>> I can also create a PR on GitHub. I am happy with both as long as I
>>> don't have to retain the patch for myself only ;-)
>>
>> Yeah that patch to git.git should be done separately. I see your PR
>> went in upstream, here's a patch to update our code to match.
>
> To avoid misunderstandings, I have factored out the Git patch and
> created a PR: https://github.com/git/git/pull/608
Thanks. If you want to submit it for inclusion you'll need to submit it
as a patch here to the ML as described here:
https://github.com/git/git/blob/master/Documentation/SubmittingPatches
Or you can use this pull-request-by-proxy thing:
https://gitgitgadget.github.io/
Or if you don't want to deal with any of that crap just say and I'll
E-Mail this to the list for you. Just want to give you a chance to do it
:)
> Looks good to me now:
>> osipovmi@deblndw024v:~/git
>> $ uname -a
>> HP-UX deblndw0 B.11.31 U ia64 HP-UX
>> osipovmi@deblndw024v:~/git
>> $ ./git --version
>> git version 2.22.0.rc0.dirty
>> osipovmi@deblndw024v:~/git
>> $ ldd ./git
>>
>> ./git:
>> libz.so => /opt/ports/lib/hpux32/libz.so
>> libiconv.so.8 => /opt/ports/lib/hpux32/libiconv.so.8
>> libintl.so.9 => /opt/ports/lib/hpux32/libintl.so.9
>> libc.so.1 => /usr/lib/hpux32/libc.so.1
>> libc.so.1 => /usr/lib/hpux32/libc.so.1
>> libc.so.1 => /usr/lib/hpux32/libc.so.1
>> libc.so.1 => /usr/lib/hpux32/libc.so.1
>> libdl.so.1 => /usr/lib/hpux32/libdl.so.1
>
> Looking forward for a merge.
>
> Regards,
>
> Michael
next prev parent reply other threads:[~2019-05-15 11:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 10:45 [PATCH] Improving HP-UX support Osipov, Michael
2019-05-09 7:32 ` Ævar Arnfjörð Bjarmason
2019-05-09 8:09 ` Osipov, Michael
2019-05-13 22:17 ` [PATCH] sha1dc: update from upstream Ævar Arnfjörð Bjarmason
2019-05-14 11:17 ` Osipov, Michael
2019-05-15 11:48 ` Ævar Arnfjörð Bjarmason [this message]
2019-05-16 7:13 ` Osipov, Michael
2019-05-16 8:31 ` Ævar Arnfjörð Bjarmason
2019-05-16 8:40 ` Osipov, Michael
2019-05-16 9:34 ` [PATCH] configure: Detect linking style for HP aCC on HP-UX Ævar Arnfjörð Bjarmason
2019-05-16 18:05 ` [PATCH] Makefile: remove the NO_R_TO_GCC_LINKER flag Ævar Arnfjörð Bjarmason
2019-05-16 22:25 ` Jeff King
2019-05-16 23:21 ` Junio C Hamano
2019-05-17 0:23 ` Jeff King
2019-05-17 21:58 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2019-05-19 0:56 ` Junio C Hamano
2019-05-19 5:01 ` Jeff King
2019-06-07 14:51 ` [PATCH] configure: Detect linking style for HP aCC on HP-UX Osipov, Michael
2019-06-07 17:03 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2018-08-01 7:31 Is detecting endianness at compile-time unworkable? Ævar Arnfjörð Bjarmason
2018-08-02 20:50 ` [PATCH] sha1dc: update from upstream Ævar Arnfjörð Bjarmason
2018-08-02 21:29 ` Michael Felt (aixtools)
2018-08-02 21:32 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7fovsz8.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=michael.osipov@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).