From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E5835C433B4
	for <git@archiver.kernel.org>; Fri, 30 Apr 2021 16:49:03 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id C5D68613D9
	for <git@archiver.kernel.org>; Fri, 30 Apr 2021 16:49:03 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229901AbhD3Qtv (ORCPT <rfc822;git@archiver.kernel.org>);
        Fri, 30 Apr 2021 12:49:51 -0400
Received: from mav.lukeshu.com ([104.207.138.63]:46424 "EHLO mav.lukeshu.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229579AbhD3Qtu (ORCPT <rfc822;git@vger.kernel.org>);
        Fri, 30 Apr 2021 12:49:50 -0400
Received: from lukeshu-dw-thinkpad (unknown [IPv6:2601:281:8200:26:4e34:88ff:fe48:5521])
        by mav.lukeshu.com (Postfix) with ESMTPSA id 61D9580590;
        Fri, 30 Apr 2021 12:48:59 -0400 (EDT)
Date:   Fri, 30 Apr 2021 10:48:58 -0600
Message-ID: <87fsz7pvk5.wl-lukeshu@lukeshu.com>
From:   Luke Shumaker <lukeshu@lukeshu.com>
To:     Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     Luke Shumaker <lukeshu@lukeshu.com>, git@vger.kernel.org,
        Avery Pennarun <apenwarr@gmail.com>,
        Charles Bailey <cbailey32@bloomberg.net>,
        Danny Lin <danny0838@gmail.com>,
        "David A . Greene" <greened@obbligato.org>,
        David Aguilar <davvid@gmail.com>,
        James Denholm <nod.helm@gmail.com>, Jeff King <peff@peff.net>,
        Jonathan Nieder <jrnieder@gmail.com>,
        Junio C Hamano <gitster@pobox.com>,
        =?UTF-8?B?Tmd1eeG7hW4g?= =?ISO-8859-1?Q?Th=E1i_?=
         =?UTF-8?B?Tmfhu41j?= Duy <pclouds@gmail.com>,
        Roger L Strain <roger.strain@swri.org>,
        Techlive Zheng <techlivezheng@gmail.com>,
        Eric Sunshine <sunshine@sunshineco.com>,
        =?ISO-8859-1?Q?=C6var_Arnfj=F6r=F0?= Bjarmason <avarab@gmail.com>,
        Luke Shumaker <lukeshu@datawire.io>
Subject: Re: [PATCH v3 10/30] subtree: t7900: add a test for the -h flag
In-Reply-To: <565bbf80-9bdb-699c-ed27-107923e4b94a@gmail.com>
References: <20210426174525.3937858-1-lukeshu@lukeshu.com>
        <20210427211748.2607474-1-lukeshu@lukeshu.com>
        <20210427211748.2607474-11-lukeshu@lukeshu.com>
        <565bbf80-9bdb-699c-ed27-107923e4b94a@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0
 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

On Fri, 30 Apr 2021 06:22:50 -0600,
Bagas Sanjaya wrote:
> 
> On 28/04/21 04.17, Luke Shumaker wrote:
> > It's a dumb test, but it's surprisingly easy to break.
> 
> Why did you say that? Very sensitive?

Because I very nearly sent v1 of this patchset with a broken '-h' flag
:)

I don't recall for certain, but I think the mistake I made was
allowing the ordering of `eval "$(echo "$OPTS_SPEC" | git rev-parse
--parseopt -- "$@")"` and `. git-sh-setup` to get flipped.  That
certainly will break '-h', anyway.

-- 
Happy hacking,
~ Luke Shumaker