git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: git@vger.kernel.org
Cc: Elijah Newren <newren@gmail.com>
Subject: [BUG?] ls-files -o now traverses nested repo when given multiple pathspecs
Date: Tue, 03 Dec 2019 17:08:00 -0500	[thread overview]
Message-ID: <87fti15agv.fsf@kyleam.com> (raw)

89a1f4aaf7 (dir: if our pathspec might match files under a dir, recurse
into it, 2019-09-17) introduced a change in behavior in terms of
traversing untracked nested repositories.  Say we have a repository that
contains a single untracked repository with untracked content:

    $ git init && git init a && touch a/x

Calling ls-files with the nested repository as the sole pathspec does
not recurse into that repository:

    $ git ls-files --other a
    a/

However, as of 89a1f4aaf7, adding an additional pathspec results in the
nested repository being traversed:

    $ git ls-files --other a foo
    a/
    a/x

Reading 89a1f4aaf7 and skimming the patch series and related thread [*],
I haven't found anything that makes me think this change in behavior was
intentional.

[*]: https://lore.kernel.org/git/20190905154735.29784-1-newren@gmail.com/

             reply	other threads:[~2019-12-03 22:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03 22:08 Kyle Meyer [this message]
2019-12-04 17:30 ` [BUG?] ls-files -o now traverses nested repo when given multiple pathspecs Elijah Newren
2019-12-04 19:42   ` Junio C Hamano
2019-12-04 20:04   ` Kyle Meyer
2019-12-08  5:31     ` Kyle Meyer
2019-12-08  5:42       ` Elijah Newren
2019-12-08  7:46         ` Elijah Newren
2019-12-08 22:59           ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fti15agv.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).