From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] config: allow specifying config entries via envvar pairs
Date: Fri, 13 Nov 2020 14:04:40 +0100 [thread overview]
Message-ID: <87mtzlflw7.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <44e8dd50c6ea7cbcc5e4fc35c9b9057c0a52038c.1605269465.git.ps@pks.im>
On Fri, Nov 13 2020, Patrick Steinhardt wrote:
> While not document, it is currently possible to specify config entries
"While not documented..."
> + strbuf_addf(&envvar, "GIT_CONFIG_KEY_%d", i);
> + if ((key = getenv(envvar.buf)) == NULL)
> + break;
The convention in git.git is to avoid explicit NULL checks. So maybe
something like this, which also avoids the assignment inside an "if"
key = getenv(envvar.buf);
if (!key)
break;
> +test_expect_success 'git config handles environment config pairs' '
> + GIT_CONFIG_KEY_1="pair.one" GIT_CONFIG_VALUE_1="foo" \
> + GIT_CONFIG_KEY_2="pair.two" GIT_CONFIG_VALUE_2="bar" \
> + GIT_CONFIG_KEY_4="pair.four" GIT_CONFIG_VALUE_4="not-parsed" \
> + git config --get-regexp "pair.*" >actual &&
> + cat >expect <<-EOF &&
> + pair.one foo
> + pair.two bar
> + EOF
> + test_cmp expect actual
> +'
> +
> +test_expect_success 'git config copes with missing config pair value' '
> + GIT_CONFIG_KEY_1="pair.one" git config --get-regexp "pair.*" >actual &&
> + echo pair.one >expect &&
> + test_cmp expect actual
> +'
> +
> +test_expect_success 'git config fails with invalid config pair key' '
> + test_must_fail env GIT_CONFIG_KEY_1= git config --list &&
> + test_must_fail env GIT_CONFIG_KEY_1=missing-section git config --list
> +'
> +
> test_expect_success 'git config --edit works' '
> git config -f tmp test.value no &&
> echo test.value=yes >expect &&
I think we should have a bit more complete tests of what happens if you
clobber existing config keys, and testing that this is set last after
system/global/local config.
next prev parent reply other threads:[~2020-11-13 13:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 12:16 [PATCH 0/2] config: allow specifying config entries via envvar pairs Patrick Steinhardt
2020-11-13 12:16 ` [PATCH 1/2] config: extract function to parse config pairs Patrick Steinhardt
2020-11-13 12:16 ` [PATCH 2/2] config: allow specifying config entries via envvar pairs Patrick Steinhardt
2020-11-13 13:04 ` Ævar Arnfjörð Bjarmason [this message]
2020-11-16 19:39 ` Junio C Hamano
2020-11-17 2:34 ` Jeff King
2020-11-17 6:37 ` Patrick Steinhardt
2020-11-17 7:01 ` Jeff King
2020-11-17 14:22 ` Ævar Arnfjörð Bjarmason
2020-11-17 23:57 ` Jeff King
2020-11-18 13:44 ` Ævar Arnfjörð Bjarmason
2020-11-18 0:50 ` brian m. carlson
2020-11-18 1:59 ` Jeff King
2020-11-18 2:25 ` brian m. carlson
2020-11-18 7:04 ` Patrick Steinhardt
2020-11-19 2:11 ` brian m. carlson
2020-11-19 6:37 ` Patrick Steinhardt
2020-11-18 5:44 ` Junio C Hamano
2020-11-17 6:28 ` Patrick Steinhardt
2020-11-17 7:06 ` Junio C Hamano
2020-11-18 13:49 ` Ævar Arnfjörð Bjarmason
2020-11-18 13:56 ` Patrick Steinhardt
2020-11-18 16:01 ` Junio C Hamano
2020-11-17 14:03 ` Ævar Arnfjörð Bjarmason
2020-11-13 16:37 ` Philip Oakley
2020-11-17 6:40 ` Patrick Steinhardt
2020-11-13 13:11 ` [PATCH 0/2] " Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtzlflw7.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).