From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Hamza Mahfooz <someguy@effective-light.com>
Subject: hm/paint-hits-in-log-grep
Date: Tue, 05 Oct 2021 18:47:46 +0200 [thread overview]
Message-ID: <87r1czjtzu.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqo884tkxd.fsf@gitster.g>
On Mon, Oct 04 2021, Junio C Hamano wrote:
> * hm/paint-hits-in-log-grep (2021-09-29) 3 commits
> - pretty: colorize pattern matches in commit messages
> - grep: refactor next_match() and match_one_pattern() for external use
> - Merge branch 'jk/grep-haystack-is-read-only' into hm/paint-hits-in-log-grep
> (this branch uses jk/grep-haystack-is-read-only.)
>
> "git log --grep=string --author=name" learns to highlight hits just
> like "git grep string" does.
>
> Will merge to 'next'?
Encodings, timezones and ... taxes? Anyway.
I tested this and it LGTM, but I found a bug in how it handles UTF-8 &
interacts with i18n.{log,commit}Encoding. See
https://lore.kernel.org/git/87v92bju64.fsf@evledraar.gmail.com/
I've got a WIP patch there on top (which I forgot to include a
Signed-off-by, but Hamza: You can assume it's there:). It *should* be
fairly easy to fix in a final v11, but maybe I've only gleamed the entry
of that particular rabbit hole so far ... :)
next prev parent reply other threads:[~2021-10-05 16:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 23:44 What's cooking in git.git (Oct 2021, #01; Mon, 4) Junio C Hamano
2021-10-04 23:52 ` Taylor Blau
2021-10-05 16:01 ` ab/refs-errno-cleanup Ævar Arnfjörð Bjarmason
2021-10-05 16:47 ` Ævar Arnfjörð Bjarmason [this message]
2021-10-05 17:07 ` ab/designated-initializers-more Ævar Arnfjörð Bjarmason
2021-10-05 20:47 ` ab/fsck-unexpected-type (and "cat-file replace handling and optimization") Ævar Arnfjörð Bjarmason
2021-10-05 22:01 ` Jeff King
2021-10-06 8:54 ` Ævar Arnfjörð Bjarmason
2021-10-07 21:37 ` Junio C Hamano
2021-10-08 2:25 ` Jeff King
2021-10-08 20:50 ` Junio C Hamano
2021-10-06 10:14 ` ab/make-sparse-for-real Ævar Arnfjörð Bjarmason
2021-10-06 10:17 ` ab/parse-options-cleanup & ab/align-parse-options-help & ab/help-config-vars Ævar Arnfjörð Bjarmason
2021-10-06 16:44 ` Junio C Hamano
2021-10-06 10:26 ` ab/refs-errno-cleanup & "errno" removal in the refs backend Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1czjtzu.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=someguy@effective-light.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).