From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: lilinchao@oschina.cn
Cc: git@vger.kernel.org, dstolee@microsoft.com, gitster@pobox.com
Subject: Re: [PATCH] builtin/gc: warn when core.commitGraph is disabled
Date: Mon, 10 May 2021 13:55:53 +0200 [thread overview]
Message-ID: <87tunau7ia.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <510425b8b17411eb93770026b95c99cc@oschina.cn>
On Mon, May 10 2021, lilinchao@oschina.cn wrote:
> From: Li Linchao <lilinchao@oschina.cn>
>
> Throw warning message when core.commitGraph is disabled in commit-graph
> maintenance task.
Won't this cause the gc.log issue noted in
https://lore.kernel.org/git/87r1l27rae.fsf@evledraar.gmail.com/
More importantly, I don't think this UX makes sense. We said we didn't
want it, so why warn about it?
Maybe there are good reasons to, but this commit message / patch doesn't
make the case for it...
> Signed-off-by: Li Linchao <lilinchao@oschina.cn>
> ---
> builtin/gc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/builtin/gc.c b/builtin/gc.c
> index 98a803196b..90684ca3b3 100644
> --- a/builtin/gc.c
> +++ b/builtin/gc.c
> @@ -861,8 +861,10 @@ static int run_write_commit_graph(struct maintenance_run_opts *opts)
> static int maintenance_task_commit_graph(struct maintenance_run_opts *opts)
> {
> prepare_repo_settings(the_repository);
> - if (!the_repository->settings.core_commit_graph)
> + if (!the_repository->settings.core_commit_graph) {
> + warning(_("skipping commit-graph task because core.commitGraph is disabled"));
> return 0;
> + }
>
> close_object_store(the_repository->objects);
> if (run_write_commit_graph(opts)) {
next prev parent reply other threads:[~2021-05-10 12:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 9:43 [PATCH] builtin/gc: warn when core.commitGraph is disabled lilinchao
2021-05-10 11:55 ` Ævar Arnfjörð Bjarmason [this message]
2021-05-13 8:17 ` lilinchao
2021-05-13 11:24 ` Ævar Arnfjörð Bjarmason
2021-05-10 18:12 ` Junio C Hamano
[not found] ` <ceb22d54b18611ebb304a4badb2c2b1147508@gmail.com>
2021-05-11 2:17 ` lilinchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tunau7ia.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lilinchao@oschina.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).