From: "Ævar Arnfjörð Bjarmason" <firstname.lastname@example.org> To: Matheus Tavares <email@example.com> Cc: firstname.lastname@example.org, email@example.com Subject: Re: [PATCH] t2080: fix cp invocation to copy symlinks instead of following them Date: Mon, 31 May 2021 22:41:12 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On Mon, May 31 2021, Matheus Tavares wrote: > On Mon, May 31, 2021 at 11:16 AM Ævar Arnfjörð Bjarmason <firstname.lastname@example.org> wrote: >> >> There's still a failure in t2082-parallel-checkout-attributes.sh >> though, which is new in 2.32.0-rc*. The difference is in an unexpected >> BOM: >> >> avar@gcc119:[/scratch/avar/git/t]perl -nle 'print unpack "H*"' trash\ directory.t2082-parallel-checkout-attributes/encoding/A.internal >> efbbbf74657874 >> avar@gcc119:[/scratch/avar/git/t]perl -nle 'print unpack "H*"' trash\ directory.t2082-parallel-checkout-attributes/encoding/utf8-text >> 74657874 >> >> I.e. the A.internal starts with 0xefbbbf. The 2nd test of t0028*.sh also >> fails similarly, so perhaps it's some old/iconv/whatever issue not >> per-se related to any change of yours. > > I ran t2080 on the same machine (gcc119) to try debugging it but I could > not reproduce the test failure . t0028 also passed here. Could it be > that we are building git differently? I did `gmake CC=gcc NO_CURL=YesPlease`. t2080 is fine, it's t2082 that's broken. But yes, we are using different parameters. This works for me: gmake CC=gcc -j3 CFLAGS="-g -O2" NO_CURL=UnfortunatelyNot This doesn't: gmake CC=xlc -j3 CFLAGS="-g -O2 -qmaxmem=524288" NO_CURL=UnfortunatelyNot The reason I test on AIX / Solaris is to get from under the GNU-isms of various libraries & away from the gcc/clang mono(bio?)culture. I.e. you're testing with GNU iconv, but IBM also has its own implementation: https://www.ibm.com/docs/en/aix/7.1?topic=programming-understanding-libiconv of that POSIX interface: https://pubs.opengroup.org/onlinepubs/9699919799/functions/iconv.html Perhaps we've had some GNU-ism slip in somewhere...
next prev parent reply other threads:[~2021-05-31 20:44 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-26 23:58 Matheus Tavares 2021-05-27 7:25 ` Christian Couder 2021-05-27 12:51 ` Ævar Arnfjörð Bjarmason 2021-05-31 14:01 ` Ævar Arnfjörð Bjarmason 2021-05-31 16:09 ` Matheus Tavares 2021-05-31 20:41 ` Ævar Arnfjörð Bjarmason [this message] 2021-06-02 1:36 ` Đoàn Trần Công Danh 2021-06-02 10:50 ` Ævar Arnfjörð Bjarmason 2021-06-02 11:14 ` Bagas Sanjaya 2021-06-02 11:22 ` Đoàn Trần Công Danh 2021-06-02 13:36 ` Ævar Arnfjörð Bjarmason 2021-06-02 13:50 ` Đoàn Trần Công Danh 2021-06-03 12:34 ` Đoàn Trần Công Danh 2021-06-02 19:13 ` UTF-BOM was: [PATCH] t2080: fix cp invocation Torsten Bögershausen 2021-06-03 0:07 ` [PATCH] t2080: fix cp invocation to copy symlinks instead of following them brian m. carlson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] t2080: fix cp invocation to copy symlinks instead of following them' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).