From: Derrick Stolee <derrickstolee@github.com>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 0/6] unused function parameter potpourri
Date: Fri, 19 Aug 2022 15:08:03 -0400 [thread overview]
Message-ID: <892b2a45-1b6b-aa87-4902-471793135183@github.com> (raw)
In-Reply-To: <Yv9Oay+tNqhLDqVl@coredump.intra.peff.net>
On 8/19/2022 4:48 AM, Jeff King wrote:
> Here are a few small cleanups of unused function parameters. The first
> five just drop the unused parameters. These are all trivially correct,
> since otherwise the compiler would complain. But I tried to make sure
> that dropping was the right thing in each (rather than it being a bug
> where the parameter should have been used).
>
> The final one just uses the parameters for an assertion, following a
> pattern we've used before.
>
> I'll try to cc the individual authors for each patch.
>
> [1/6]: xdiff: drop unused mmfile parameters from xdl_do_histogram_diff()
> [2/6]: log-tree: drop unused commit param in remerge_diff()
> [3/6]: match_pathname(): drop unused "flags" parameter
> [4/6]: verify_one_sparse(): drop unused repository parameter
> [5/6]: reftable: drop unused parameter from reader_seek_linear()
> [6/6]: reflog: assert PARSE_OPT_NONEG in parse-options callbacks
Thanks for doing this cleanup. It all looks correct to me.
Patch 5 mentioned some choice as to modifying the parameter list
versus using the UNUSED() macro. I think renaming the method can
solve the uncertainty there, but it's also not necessary for the
change to be correct.
Thanks,
-Stolee
next prev parent reply other threads:[~2022-08-19 19:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 8:48 [PATCH 0/6] unused function parameter potpourri Jeff King
2022-08-19 8:49 ` [PATCH 1/6] xdiff: drop unused mmfile parameters from xdl_do_histogram_diff() Jeff King
2022-08-19 13:32 ` Phillip Wood
2022-08-20 6:58 ` Jeff King
2022-08-20 7:36 ` [PATCH 7/6] xdiff: drop unused mmfile parameters from xdl_do_patience_diff() Jeff King
2022-08-26 13:15 ` Phillip Wood
2022-08-19 8:50 ` [PATCH 2/6] log-tree: drop unused commit param in remerge_diff() Jeff King
2022-08-19 23:05 ` Elijah Newren
2022-08-20 7:04 ` Jeff King
2022-08-19 8:50 ` [PATCH 3/6] match_pathname(): drop unused "flags" parameter Jeff King
2022-08-19 8:51 ` [PATCH 4/6] verify_one_sparse(): drop unused repository parameter Jeff King
2022-08-19 19:04 ` Derrick Stolee
2022-08-20 7:01 ` Jeff King
2022-08-20 8:48 ` René Scharfe
2022-08-20 9:02 ` [PATCH v2 " Jeff King
2022-08-19 8:54 ` [PATCH 5/6] reftable: drop unused parameter from reader_seek_linear() Jeff King
2022-08-19 19:06 ` Derrick Stolee
2022-08-22 7:46 ` Han-Wen Nienhuys
2022-08-19 8:55 ` [PATCH 6/6] reflog: assert PARSE_OPT_NONEG in parse-options callbacks Jeff King
2022-08-19 19:08 ` Derrick Stolee [this message]
2022-08-19 23:07 ` [PATCH 0/6] unused function parameter potpourri Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=892b2a45-1b6b-aa87-4902-471793135183@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).