From: "René Scharfe" <l.s.r@web.de>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] perf: fix test_export with SHELL=zsh
Date: Sat, 2 Oct 2021 11:40:02 +0200 [thread overview]
Message-ID: <8b70d04f-0ad1-6e68-f5a2-2d8ec3bb98ea@web.de> (raw)
Unlike other shells, zsh doesn't do word-splitting on variables. This
is documented in https://zsh.sourceforge.io/FAQ/zshfaq03.html#31. That
breaks the perf function test_export because it uses a space-separated
variable as a poor man's array, and as a consequence p0000 fails with
"not ok 3 - test_export works". Pass the value through an unquoted
command substitution to force word-splitting even in zsh.
Signed-off-by: René Scharfe <l.s.r@web.de>
---
t/perf/perf-lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh
index f5ed092ee5..f74cfd35d6 100644
--- a/t/perf/perf-lib.sh
+++ b/t/perf/perf-lib.sh
@@ -165,7 +165,7 @@ test_export () {
'"$1"'
ret=$?
needles=
-for v in $test_export_
+for v in $(echo "$test_export_")
do
needles="$needles;s/^$v=/export $v=/p"
done
--
2.33.0
next reply other threads:[~2021-10-02 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 9:40 René Scharfe [this message]
2021-10-02 11:26 ` [PATCH] perf: fix test_export with SHELL=zsh Johannes Altmanninger
2021-10-07 18:47 ` [PATCH] t/perf: do not run tests in user's $SHELL Johannes Altmanninger
2021-10-08 3:07 ` Jeff King
2021-10-08 5:34 ` Johannes Altmanninger
2021-10-08 5:41 ` Jeff King
2021-10-02 21:02 ` [PATCH] perf: fix test_export with SHELL=zsh brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b70d04f-0ad1-6e68-f5a2-2d8ec3bb98ea@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).