git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org,
	Eric Sunshine via GitGitGadget <gitgitgadget@gmail.com>
Subject: Re: [PATCH 0/3] fix t1509-root-work-tree failure
Date: Thu, 8 Dec 2022 13:10:04 +0100 (CET)	[thread overview]
Message-ID: <96178n12-4255-q093-qo51-r37n5o569s6p@tzk.qr> (raw)
In-Reply-To: <CAPig+cT6z5kzM8suwqxJ0wrzHjnj9ChROVBiQO3AR1rJ11pkNw@mail.gmail.com>

Hi Eric,

On Mon, 5 Dec 2022, Eric Sunshine wrote:

> On Sun, Nov 20, 2022 at 10:00 PM Eric Sunshine via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > The t1509-root-work-tree script started failing earlier this year but went
> > unnoticed because the script is rarely run since it requires setting up a
> > chroot environment or a sacrificial virtual machine. This patch series fixes
> > the failure and makes it a bit easier to run the script repeatedly without
> > it tripping over itself.
> >
> > Eric Sunshine (3):
> >   t1509: fix failing "root work tree" test due to owner-check
> >   t1509: make "setup" test more robust
> >   t1509: facilitate repeated script invocations
>
> Ping?

Thank you for the ping. I did not have much time for the Git mailing list
as of late (too much Git for Windows stuff going on).

The patch series looks good to me, with or without the `test_atexit`
change I suggested.

Thank you,
Johannes

  reply	other threads:[~2022-12-08 12:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21  3:00 [PATCH 0/3] fix t1509-root-work-tree failure Eric Sunshine via GitGitGadget
2022-11-21  3:00 ` [PATCH 1/3] t1509: fix failing "root work tree" test due to owner-check Eric Sunshine via GitGitGadget
2022-12-08 11:49   ` Johannes Schindelin
2022-11-21  3:00 ` [PATCH 2/3] t1509: make "setup" test more robust Eric Sunshine via GitGitGadget
2022-12-08 11:49   ` Johannes Schindelin
2022-11-21  3:00 ` [PATCH 3/3] t1509: facilitate repeated script invocations Eric Sunshine via GitGitGadget
2022-12-06  2:42   ` Ævar Arnfjörð Bjarmason
2022-12-06  3:23     ` Eric Sunshine
2022-12-08 12:04       ` Johannes Schindelin
2022-12-08 13:14         ` "test_atexit" v.s. "test_when_finished" (was: [PATCH 3/3] t1509: facilitate repeated script invocations) Ævar Arnfjörð Bjarmason
2022-12-09  4:46           ` "test_atexit" v.s. "test_when_finished" Junio C Hamano
2022-12-05 18:21 ` [PATCH 0/3] fix t1509-root-work-tree failure Eric Sunshine
2022-12-08 12:10   ` Johannes Schindelin [this message]
2022-12-09  4:59     ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96178n12-4255-q093-qo51-r37n5o569s6p@tzk.qr \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).