archive mirror
 help / color / mirror / Atom feed
From: Max Horn <>
To: Felipe Contreras <>
Cc: Junio C Hamano <>,
Subject: Re: My patches
Date: Fri, 18 Oct 2013 13:21:07 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <52605a36eef0f_448145fe7466@nysa.notmuch>

[-- Attachment #1: Type: text/plain, Size: 4417 bytes --]

I guess most other people keep out of this because they are sensible enough to not feed the troll, and instead focus on useful things. But I can't help it, I have to say this.

On 17.10.2013, at 23:44, Felipe Contreras <> wrote:

> Junio C Hamano wrote:
>> Felipe Contreras <> writes:
>>> Junio C Hamano wrote:
>>>> Such a review comment and the discussion that follows it after a
>>>> patch is posted is an essential part of the collaborative
>>>> development process in this community and it has helped the quality
>>>> of our end product. We unfortunately saw time and again that the
>>>> process rarely works when the discussion involves your patches.
>>> No, you did not. What you saw was a person that unlike a trained dog, argued
>>> against you. And apparently your definition of a good discussion is one in
>>> which the other person just does what you say, and doesn't argue back.
>> That is so untrue that it is not even funny.
> It is true, and there's penty of evidence that proves it.

No, it is not true, and there is plenty of evidence that proves it.

But I don't think it's helpful for either of us drag up such "evidence", as it'll convince nobody -- indeed, I am sure almost everybody here has already formed a clear opinion on this matter. And I hazard to guess that the vast majority agree with Junio on this (based, again, on email evidence). Not with you.

Of course one can't prove mathematical theorems by a majority vote, but as we are not talking about theorems, but rather about judging whether Junion's behavior is considered fair or not, I think it is appropriate to. Moreover, if I look at e.g. the "staging area" discussion, you also bring up the "everybody but Junio and one other guy" argument (incorrectly generalizing from "those people on this mailing list who chose to reply" to "everybody"), so I think I am entitled to do the same ;-).

(BTW, I am actually in favor of using the term "staging area" over "index")

> Every single time that you get mad at me, it's because I disagree with you.

I have not yet seen Junio get "mad" here, even in discussions with you were I think most other people would indeed have gotten "mad" at you. He stays remarkably polite, despite the insults and dirt you keep flinging at him... If at all, it would seem that you are getting mad at Junio.

>> Contributors often make sensible counter-arguments and/or explain
>> the rationale better than they did in their original messages, and
>> then receive a "Thanks for a dose of sanity" (or an equivalent
>> phrased in different ways).
> Yes, when there's an agreement, so you are basically proving what I said. I
> disagree with you, you disagree with me, and that means I'm the problem.

Actually, it is more like this: "Felipe disagrees with Junio, Junio disagrees with Felipe, Felipe insults Junio and in passing half a dozen other people." It is the latter point which makes the situation asymmetric, and indeed indicates you as the problem.

> In any healthy collaborative project that simply means there was a
> disagreement, and that's that.

If your premise was correct (that there is simply a disagreement), then this conclusion might be correct. As it is, though, your premise is false. The problem is rather a disruptive person: you. Quite sad, since you seem to have some good ideas and code contributions! I am in particular grateful for your work on remote helpers, both on specific ones (git-remote-hg) and also on improving the whole remote helper interface. I hope some of this work can eventually be merged...

But at the end of the day, we most (all?) of us here are volunteers, and unlike what you seem to claim a lot, for most of us, making git better is *not* the number 1 priority in our lives... In particular, if working with you would make git better, but at the same time would give me ulcers, well, my choice is clear to me... Perhaps it wouldn't be best for git, but I don't think anybody (except, perhaps, you) would blame me for it. Or, for that matter, Junio. 

@Junio: Thank you for being an opinionated but also very fair project lead, who listens to *constructive* feedback, and has again and again demonstrated through action a readiness to revise a position based on sensible discussions conducted on this list.


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 235 bytes --]

  reply	other threads:[~2013-10-18 11:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-12  7:24 My patches Felipe Contreras
2013-10-12 16:18 ` Philip Oakley
2013-10-12 22:33   ` Felipe Contreras
2013-10-14 17:42 ` Junio C Hamano
2013-10-14 21:40   ` Felipe Contreras
2013-10-17 19:54     ` Junio C Hamano
2013-10-17 21:44       ` Felipe Contreras
2013-10-18 11:21         ` Max Horn [this message]
2013-10-18 11:41           ` Felipe Contreras
2013-10-18 15:30             ` Theodore Ts'o
2013-10-18 15:49               ` Felipe Contreras
2013-10-18 16:59               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).