From: Philip Oakley <philipoakley@iee.email>
To: Jeff King <peff@peff.net>
Cc: GitList <git@vger.kernel.org>,
Pratyush Yadav <me@yadavpratyush.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v4] Doc: Bundle file usage
Date: Sun, 20 Oct 2019 11:49:19 +0100 [thread overview]
Message-ID: <9e097bb2-ff3e-db5b-f0fd-0803e56b2cd6@iee.email> (raw)
In-Reply-To: <20191020011020.GA2980@sigill.intra.peff.net>
On 20/10/2019 02:10, Jeff King wrote:
> On Fri, Oct 18, 2019 at 09:30:52PM +0100, Philip Oakley wrote:
>
>> +`git clone` can use any bundle created without negative refspecs
>> +(e.g., `new`, but not `old..new`).
>> +If you want to match `git clone --mirror`, which would clone other
>> +refs such as `refs/remotes/*`, use `--all`.
>> +If you want to provide the same set of refs that a clone directly
>> +from the source repository would get, use `--branches --tags` for
>> +the `<git-rev-list-args>`.
> Since you swapped the order here of "--mirror" versus non-mirror, saying
> "other refs such as..." in the first part is confusing. We haven't
> introduced the thing they're "other" from.
>
> Maybe say "clone all refs (including ones which would be omitted by a
> non-mirror clone, like refs/remotes/*)" or something?
>
> Other than that, this version looks OK to me.
>
I had deliberately swapped the order because of the classic human
fallibility of only remembering the beginning and end parts, so I'd
buried' the --mirror/--all option, leaving that important bit to the end.
I'll probably simply just drop the word "other" (or maybe "include cloning")
Philip
next prev parent reply other threads:[~2019-10-20 10:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 23:25 [PATCHv2 1/8] Doc: Bundle file usage Philip Oakley
2012-09-18 23:55 ` Junio C Hamano
2019-10-16 9:57 ` [PATCH v2] " Philip Oakley
2019-10-16 10:15 ` Philip Oakley
2019-10-16 21:09 ` Jeff King
2019-10-17 2:54 ` Junio C Hamano
2019-10-18 15:15 ` [PATCH v3] " Philip Oakley
2019-10-18 18:15 ` Pratyush Yadav
2019-10-18 19:58 ` Philip Oakley
2019-10-18 20:30 ` [PATCH v4] " Philip Oakley
2019-10-20 1:10 ` Jeff King
2019-10-20 10:49 ` Philip Oakley [this message]
2019-10-20 11:03 ` [PATCH v5] " Philip Oakley
2019-10-21 2:48 ` Junio C Hamano
2019-10-21 3:16 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e097bb2-ff3e-db5b-f0fd-0803e56b2cd6@iee.email \
--to=philipoakley@iee.email \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@yadavpratyush.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).