From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Cc: Sverre Rabbelier <srabbelier@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] rebase: pass --signoff option to git am
Date: Sun, 28 Nov 2010 09:00:08 +0100 [thread overview]
Message-ID: <AANLkTim+vJuZ9bJnROqbzN8O-K8NVyi8zHYokDNqOjqa@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1011272002090.26955@debian>
On Sat, Nov 27, 2010 at 8:05 PM, Martin von Zweigbergk
<martin.von.zweigbergk@gmail.com> wrote:
>
> On Sun, 28 Nov 2010, Sverre Rabbelier wrote:
>
>> Heya,
>>
>> On Sat, Nov 27, 2010 at 12:15, Giuseppe Bilotta
>> <giuseppe.bilotta@gmail.com> wrote:
>> > -p::
>> > --preserve-merges::
>> > Instead of ignoring merges, try to recreate them.
>> > +
>> > +--signoff::
>> > + This flag is passed to 'git am' to sign off all the rebased
>> > + commits (see linkgit:git-am[1]).
>> > + Incompatible with the --interactive option.
>>
>> The one above that does have a shorthand (-p), why should we (not?)
>> give --signoff it's customary -s shorthand here?
>
> The '-s' flag is unfortunately already taken. It is used for
> specifying a merge strategy.
In fact, this is why I was a little skeptical myself about submitting
this patch. What if people start remembering that rebase supports
--signoff and implicity assume that -s is also a valid shortcut? Funky
errors. (I've been bittem myself by similar situations for whitespace
support. Can I pass -b or not? Will it mean --ignore-whitespace?)
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2010-11-28 8:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-27 11:15 [PATCH] rebase: pass --signoff option to git am Giuseppe Bilotta
2010-11-28 0:32 ` Sverre Rabbelier
2010-11-27 19:05 ` Martin von Zweigbergk
2010-11-28 8:00 ` Giuseppe Bilotta [this message]
2010-11-29 22:57 ` Kevin Ballard
2010-11-30 8:09 ` Giuseppe Bilotta
2010-12-06 10:41 ` Giuseppe Bilotta
2010-12-06 17:28 ` Jonathan Nieder
-- strict thread matches above, loose matches on Subject: below --
2017-01-21 10:49 Giuseppe Bilotta
2017-01-23 18:13 ` Junio C Hamano
2017-01-23 20:03 ` Giuseppe Bilotta
2017-01-23 20:16 ` Junio C Hamano
2017-01-23 22:35 ` Giuseppe Bilotta
2017-01-23 23:27 ` Junio C Hamano
2017-01-24 7:06 ` Giuseppe Bilotta
2017-01-26 18:18 ` Giuseppe Bilotta
2010-09-16 9:07 Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTim+vJuZ9bJnROqbzN8O-K8NVyi8zHYokDNqOjqa@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.von.zweigbergk@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).