From: Rene Schumacher <Rene.Schumacher@microsoft.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: RE: Git Commit Signature Encoding
Date: Fri, 12 Feb 2021 10:12:28 +0000 [thread overview]
Message-ID: <AM7PR83MB043401AAFD7377B99CA1BF97EE8B9@AM7PR83MB0434.EURPRD83.prod.outlook.com> (raw)
In-Reply-To: <962853bc-9e60-968f-c64d-35757f72e8d1@gmail.com>
Hi Philippe,
thank you for the feedback. Perhaps the reason really is the gpg4win installation. I'll put together all steps I followed to set up my environment and create an issue on GitHub. Thanks for pointing me to the correct repo!
Cheers,
René
-----Original Message-----
From: Philippe Blain <levraiphilippeblain@gmail.com>
Sent: Dienstag, 9. Februar 2021 04:13
To: Rene Schumacher <Rene.Schumacher@microsoft.com>; git@vger.kernel.org
Subject: Re: Git Commit Signature Encoding
Hi René,
Le 2021-01-27 à 04:41, Rene Schumacher a écrit :
> Hi Philippe,
>
> thanks for getting back to me so quickly! And sorry for not providing all the details right away.
>
> I'm using Git 2.30.0.windows.1 (I believe that's the latest), gpg 2.2.27 (installed via gpg4win 3.1.15), and PowerShell 7.1.1. You might have seen my second email to the list in which I described that setting the OutputEncoding in PowerShell to UTF-8 fixed at least the display of the é (and probably all other umlauts and special printable characters). The signature output from git show --show-signatur is still printing the ^M carriage return character at the end of each line:
>
> commit 69022a47744fcb3801572ac5d14295bcab274295 (HEAD -> master)
> gpg: Signature made 26.01.2021 17:55:36 W. Europe Standard Time^M
> gpg: using RSA key 3848D5B2A3D45419D7F564F97802B995CDB4A2EF^M
> gpg: Good signature from "René Schumacher <rene.schumacher@microsoft.com>" [ultimate]^M
> gpg: aka "René Schumacher <reneschu@microsoft.com>" [ultimate]^M
> Author: René Schumacher <reneschu@microsoft.com>
> Date: Tue Jan 26 17:55:36 2021 +0100
>
> another commit with signature
>
> diff --git a/file1.txt b/file1.txt
> index a7f8d9e..6ddadea 100644
> --- a/file1.txt
> +++ b/file1.txt
> @@ -1 +1,2 @@
> bla
> +blub
>
> Since git verify-commit does not have those carriage return characters, I'm still wondering where they might come from.
>
> Cheers,
> René
I've tried to replicate with 2.30.0.windows.2 and gpg 2.2.27 (that comes with Git-for-Windows), and could not, neither in Git Bash, Cmd, Windows Powershell or Powershell Core 7.1.1.
Maybe if you can provide a complete reproducer with all needed steps (git init, gpg --gen-key, etc) you would get more help in the Git-for-Windows issue tracker:
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgit-for-windows%2Fgit%2Fissues&data=04%7C01%7CRene.Schumacher%40microsoft.com%7C914d70147a1945878c8208d8cca89a3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637484371825641164%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=9LgP1MLTk6s7ON4bXbS1rgSvxYKw3yytBP7D4P430oU%3D&reserved=0
Cheers,
Philippe.
prev parent reply other threads:[~2021-02-12 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AM7PR83MB0434B67B0F15E4433347D555EEBC9@AM7PR83MB0434.EURPRD83.prod.outlook.com>
2021-01-26 14:30 ` Git Commit Signature Encoding Rene Schumacher
2021-01-26 17:03 ` Rene Schumacher
2021-01-26 19:11 ` Philippe Blain
2021-01-27 9:41 ` Rene Schumacher
2021-02-09 3:12 ` Philippe Blain
2021-02-12 10:12 ` Rene Schumacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM7PR83MB043401AAFD7377B99CA1BF97EE8B9@AM7PR83MB0434.EURPRD83.prod.outlook.com \
--to=rene.schumacher@microsoft.com \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).