From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: Re* Regulator updates for 3.3 Date: Wed, 11 Jan 2012 08:23:01 -0800 Message-ID: References: <20120109073727.GF22134@opensource.wolfsonmicro.com> <20120110184530.GE7164@opensource.wolfsonmicro.com> <20120110222711.GK7164@opensource.wolfsonmicro.com> <7vmx9v7z1r.fsf@alter.siamese.dyndns.org> <7vehv77xeq.fsf@alter.siamese.dyndns.org> <7vzkdu7miv.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Mark Brown , Liam Girdwood , linux-kernel@vger.kernel.org, Git Mailing List To: Junio C Hamano X-From: linux-kernel-owner@vger.kernel.org Wed Jan 11 17:23:38 2012 Return-path: Envelope-to: glk-linux-kernel-3@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rl0xc-0000VK-2z for glk-linux-kernel-3@lo.gmane.org; Wed, 11 Jan 2012 17:23:36 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757614Ab2AKQX0 (ORCPT ); Wed, 11 Jan 2012 11:23:26 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:46261 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104Ab2AKQXX (ORCPT ); Wed, 11 Jan 2012 11:23:23 -0500 Received: by wibhm14 with SMTP id hm14so497438wib.19 for ; Wed, 11 Jan 2012 08:23:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=ntXZER73eFpzMSbPfd1B6q3H6gTFNZqooZAHB4unr2M=; b=Celfa5XpwzAb0Krg78xY+EBw6cnvhwHHc72ktj59UuHhx6z7EcJQE3XfZg6BNC22zY XNhkY5c+i/EV8gxcyCJOw2SjVX9gCsVDUGG/1VbZQJk7Cx9u27loUVM0YoE3mdWFWtk0 5ZG/fOf8fE0NIXFd0PLdl/wVJHlbAKDZ+/5Og= Received: by 10.180.19.138 with SMTP id f10mr53946196wie.3.1326299002214; Wed, 11 Jan 2012 08:23:22 -0800 (PST) Received: by 10.216.172.213 with HTTP; Wed, 11 Jan 2012 08:23:01 -0800 (PST) In-Reply-To: <7vzkdu7miv.fsf@alter.siamese.dyndns.org> X-Google-Sender-Auth: x7lpfQ3WB0_YcDUmbICwHR-iPA8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Archived-At: On Tue, Jan 10, 2012 at 10:59 PM, Junio C Hamano wrote: > > What makes me uneasy about the idea of running the editor by default is > that many people still use Git as a better CVS/SVN. Their workflow is to > build randomly on their 'master', attempt to push and get rejected, pull > only so that they can push out, and then push the merge result out. Sure. And I don't think we can do much about it. They'll either set the legacy flag, or they'll just exit the editor without adding anything useful (if you come from a CVS background in particular, you probably never learnt to do good commit logs anyway). So it will be a bit more work for the bad workflow, I agree - although if it really irritates people, they can just set that GIT_MERGE_LEGACY in their .bashrc files or something. But we can *hope* that even those people might sometimes actually talk about what/why they are doing things, or maybe even learn about that whole "distributed" thing. I agree that is unlikely to ever happen, though. It's more likely that they will change their aliases so that their "update" command just adds the --no-edit flag. Regardless, it doesn't sound *too* onerous to work around. Patch looks good to me. I would personally have compared "st_mode" instead of (or in addition to) "st_rdev", but I don't think it matters all that much. Linus