git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Perl <th.perl@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] gitweb: Fix file links in "grep" search
Date: Fri, 13 Jan 2012 15:09:27 +0100	[thread overview]
Message-ID: <CA+uOhx7QwRQJzyYBCkmVDBRCMt0i_ZqS=sfTG0VmNiVv2dVoww@mail.gmail.com> (raw)
In-Reply-To: <201201052126.49087.jnareb@gmail.com>

Hi,

2012/1/5 Jakub Narebski <jnareb@gmail.com>:
> There were two bugs in generating file links (links to "blob" view),
> one hidden by the other.  The correct way of generating file link is
>
>        href(action=>"blob", hash_base=>$co{'id'},
>             file_name=>$file);
>
> It was $co{'hash'} (this key does not exist, and therefore this is
> undef), and 'hash' instead of 'hash_base'.
> [...]
> Thomas, could you check if this fixes your issue?

Sorry for taking a bit longer to respond on this one, but I just got
around to test all problematic cases that I described with the patch
applied - it fixes the problem for me (i.e. I can successfully grep in
non-master branches and then clicking the link brings me to the right
location).

As far as I'm concerned, the patch can be applied and fixes the bug.

Thanks for the quick fix! :)
Thomas

  parent reply	other threads:[~2012-01-13 14:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-02 13:29 [BUG] gitweb generates wrong links in grep search results (git_search_files) Thomas Perl
2012-01-04  0:28 ` Junio C Hamano
2012-01-04 16:21   ` Jakub Narębski
2012-01-05 20:26     ` [PATCH 1/2] gitweb: Fix file links in "grep" search Jakub Narebski
2012-01-05 20:32       ` [PATCH 2/2] gitweb: Harden "grep" search against filenames with ':' Jakub Narebski
2012-01-13 14:09       ` Thomas Perl [this message]
2012-01-13 19:18         ` [PATCH 1/2] gitweb: Fix file links in "grep" search Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+uOhx7QwRQJzyYBCkmVDBRCMt0i_ZqS=sfTG0VmNiVv2dVoww@mail.gmail.com' \
    --to=th.perl@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).