From: Erik Faye-Lund <kusmabite@gmail.com>
To: Marat Radchenko <marat@slonopotamus.org>,
Sebastian Schuberth <sschuberth@gmail.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings
Date: Mon, 28 Apr 2014 17:17:25 +0200 [thread overview]
Message-ID: <CABPQNSa7buDJFYsaW1a51XoRnqZiVUYGSgfS1t-UiF7TnuWX5g@mail.gmail.com> (raw)
In-Reply-To: <20140428150436.GB19002@seldon>
On Mon, Apr 28, 2014 at 5:04 PM, Marat Radchenko <marat@slonopotamus.org> wrote:
> On Mon, Apr 28, 2014 at 04:58:11PM +0200, Erik Faye-Lund wrote:
>> On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko <marat@slonopotamus.org> wrote:
>> > HAVE_LIBCHARSET_H and NO_R_TO_GCC_LINKER are not specific to
>> > msysGit, they're general MinGW settings.
>>
>> Actually, HAVE_LIBCHARSET_H is. It's only present because we have
>> libiconv installed.
>
> 1. What are other ways to provide iconv on MinGW?
I'm not sure I understand. To set HAVE_LIBCHARSET_H, we need to have
libcharset.h. MinGW doesn't supply by default to my knowledge, so we
get it from iconv. The THIS_IS_MSYSGIT file is there for us to be able
to pick the right defaults for msysGit, and us having libcharset is
indeed a msysGit-detail. Not all iconv-flavors supply libcharset.h, so
this tells a particularity about the one we have in msysGit.
> 2. One can still completely disable iconv with NO_ICONV=1
Sure. And it does seem like the current setup assumes that anyone
building for MinGW has iconv. But perhaps that's a mistake?
All in all, I think maybe the line between MinGW and msysGit is a bit
blurry at the moment. On the other hand, I don't know of anyone else
than Sebastian that builds outside of msysGit.
To be honest, I think the whole THIS_IS_MSYSGIT-block should have
stayed downstream.
next prev parent reply other threads:[~2014-04-28 15:18 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 13:51 [RFC/PATCH v1] Towards MinGW(-W64) cross-compilation Marat Radchenko
2014-04-28 13:51 ` [PATCH 01/12] MINGW: config.mak.uname: add explicit way to request MinGW-build Marat Radchenko
2014-04-28 16:12 ` Jonathan Nieder
2014-04-28 13:51 ` [PATCH 02/12] MINGW: compat/bswap.h: include stdint.h Marat Radchenko
2014-04-28 14:45 ` Erik Faye-Lund
2014-04-28 14:52 ` Marat Radchenko
2014-04-28 14:54 ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 03/12] MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64 Marat Radchenko
2014-04-28 15:02 ` Erik Faye-Lund
2014-04-28 15:09 ` Marat Radchenko
2014-04-28 15:19 ` Erik Faye-Lund
2014-04-28 19:59 ` Torsten Bögershausen
2014-04-28 19:58 ` Felipe Contreras
2014-04-28 20:13 ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 04/12] Makefile: introduce CROSS_COMPILE variable Marat Radchenko
2014-04-28 16:25 ` Jonathan Nieder
2014-04-28 17:34 ` Felipe Contreras
2014-04-28 20:40 ` Marat Radchenko
2014-04-28 20:45 ` Jonathan Nieder
2014-04-28 20:54 ` Marat Radchenko
2014-04-28 17:37 ` Felipe Contreras
2014-04-28 18:15 ` Marat Radchenko
2014-04-28 18:09 ` Felipe Contreras
2014-04-28 23:38 ` Jonathan Nieder
2014-04-28 23:54 ` Felipe Contreras
2014-04-28 13:51 ` [PATCH 05/12] MINGW: git-compat-util.h: use inttypes.h for printf macros Marat Radchenko
2014-04-28 14:53 ` Erik Faye-Lund
2014-04-28 15:00 ` Marat Radchenko
2014-04-28 15:07 ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 06/12] MSVC: config.mak.uname: drop -D__USE_MINGW_ACCESS from compile definitions Marat Radchenko
2014-04-28 15:32 ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings Marat Radchenko
2014-04-28 14:58 ` Erik Faye-Lund
2014-04-28 15:04 ` Marat Radchenko
2014-04-28 15:17 ` Erik Faye-Lund [this message]
2014-04-28 16:42 ` Marat Radchenko
2014-04-28 13:51 ` [PATCH 08/12] MINGW: config.mak.uname allow using CURL for non-msysGit builds Marat Radchenko
2014-04-28 15:26 ` Erik Faye-Lund
2014-04-28 16:23 ` Marat Radchenko
2014-04-28 16:24 ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 09/12] MINGW: config.mak.uname: drop -DNOGDI Marat Radchenko
2014-04-28 14:56 ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 10/12] MINGW: config.mak.uname: drop USE_NED_ALLOCATOR Marat Radchenko
2014-04-28 15:23 ` Erik Faye-Lund
2014-04-28 16:30 ` Jonathan Nieder
2014-04-29 7:48 ` Marat Radchenko
2014-04-29 7:59 ` Felipe Contreras
2014-04-28 17:39 ` Felipe Contreras
2014-04-28 19:50 ` Philip Oakley
2014-04-28 13:51 ` [PATCH 11/12] MINGW: do not fail at redefining pid_t on MinGW-W64 Marat Radchenko
2014-04-28 15:24 ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 12/12] MINGW: compat/mingw.h: drop fork() definition Marat Radchenko
2014-04-28 15:20 ` Erik Faye-Lund
2014-04-28 15:34 ` [RFC/PATCH v1] Towards MinGW(-W64) cross-compilation Erik Faye-Lund
2014-04-29 9:11 [PATCH v2] " Marat Radchenko
2014-04-29 9:12 ` [PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings Marat Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPQNSa7buDJFYsaW1a51XoRnqZiVUYGSgfS1t-UiF7TnuWX5g@mail.gmail.com \
--to=kusmabite@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=marat@slonopotamus.org \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).