From: Elijah Newren <newren@gmail.com> To: Eric Sunshine <sunshine@sunshineco.com> Cc: Jeff King <peff@peff.net>, Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>, Git List <git@vger.kernel.org> Subject: Re: [PATCH 1/5] t7300: add testcase showing unnecessary traversal into ignored directory Date: Sat, 8 May 2021 10:20:01 -0700 [thread overview] Message-ID: <CABPp-BE4ccB3cVXMqQ-4ZPn6TrRMrD61zHrXNbtNR9GQ9id98Q@mail.gmail.com> (raw) In-Reply-To: <CAPig+cQw5xBK00rtMVw4b6e_21vgp33yYDfdRape202dpWQjbA@mail.gmail.com> On Fri, May 7, 2021 at 5:11 PM Eric Sunshine <sunshine@sunshineco.com> wrote: > > On Fri, May 7, 2021 at 8:04 PM Elijah Newren <newren@gmail.com> wrote: > > I think I figured it out. I now have the test simplified down to just: > > > > test_expect_success 'avoid traversing into ignored directories' ' > > test_when_finished rm -f output error trace.* && > > test_create_repo avoid-traversing-deep-hierarchy && > > ( > > mkdir -p untracked/subdir/with/a && > > >untracked/subdir/with/a/random-file.txt && > > > > GIT_TRACE2_PERF="$TRASH_DIRECTORY/trace.output" \ > > git clean -ffdxn -e untracked && > > > > grep data.*read_directo.*visited ../trace.output \ > > | cut -d "|" -f 9 >../trace.relevant && > > cat >../trace.expect <<-EOF && > > directories-visited:1 > > paths-visited:4 > > EOF > > test_cmp ../trace.expect ../trace.relevant > > ) > > ' > > I believe that you can close the subshell immediately after `git > clean`, which would allow you to drop all the "../" prefixes on > pathnames. Ah, good point. I'll make that fix. > > This relies on a few extra changes to the code: (1) switching the > > existing trace calls in dir.c over to using trace2 variants, and (2) > > adding two new counters (visited_directories and visited_paths) that > > are output using the trace2 framework. I'm a little unsure if I > > should check the paths-visited counter (will some platform have > > additional files in every directory besides '.' and '..'? Or not have > > one of those?), but it is good to have it check that the code in this > > case visits no directories other than the toplevel one (i.e. that > > directories-visited is 1). > > I can't find the reference, but I recall a reply by jrneider (to some > proposed patch) that not all platforms are guaranteed to have "." and > ".." entries (but I'm not sure we need to worry about that presently).
next prev parent reply other threads:[~2021-05-08 17:20 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-07 4:04 [PATCH 0/5] Directory traversal fixes Elijah Newren via GitGitGadget 2021-05-07 4:04 ` [PATCH 1/5] t7300: add testcase showing unnecessary traversal into ignored directory Elijah Newren via GitGitGadget 2021-05-07 4:27 ` Eric Sunshine 2021-05-07 5:00 ` Elijah Newren 2021-05-07 5:31 ` Eric Sunshine 2021-05-07 5:42 ` Elijah Newren 2021-05-07 5:56 ` Eric Sunshine 2021-05-07 23:05 ` Jeff King 2021-05-07 23:15 ` Eric Sunshine 2021-05-08 0:04 ` Elijah Newren 2021-05-08 0:10 ` Eric Sunshine 2021-05-08 17:20 ` Elijah Newren [this message] 2021-05-08 11:13 ` Philip Oakley 2021-05-08 17:20 ` Elijah Newren 2021-05-07 4:04 ` [PATCH 2/5] t3001, t7300: add testcase showcasing missed directory traversal Elijah Newren via GitGitGadget 2021-05-07 4:04 ` [PATCH 3/5] dir: avoid unnecessary traversal into ignored directory Elijah Newren via GitGitGadget 2021-05-07 4:04 ` [PATCH 4/5] dir: traverse into untracked directories if they may have ignored subfiles Elijah Newren via GitGitGadget 2021-05-07 4:05 ` [PATCH 5/5] [RFC] ls-files: error out on -i unless -o or -c are specified Elijah Newren via GitGitGadget 2021-05-07 16:22 ` [PATCH 6/5] dir: update stale description of treat_directory() Derrick Stolee 2021-05-07 17:57 ` Elijah Newren 2021-05-07 16:27 ` [PATCH 0/5] Directory traversal fixes Derrick Stolee 2021-05-08 0:08 ` [PATCH v2 0/8] " Elijah Newren via GitGitGadget 2021-05-08 0:08 ` [PATCH v2 1/8] t7300: add testcase showing unnecessary traversal into ignored directory Elijah Newren via GitGitGadget 2021-05-08 10:13 ` Junio C Hamano 2021-05-08 17:34 ` Elijah Newren 2021-05-08 10:19 ` Junio C Hamano 2021-05-08 17:41 ` Elijah Newren 2021-05-08 0:08 ` [PATCH v2 2/8] t3001, t7300: add testcase showcasing missed directory traversal Elijah Newren via GitGitGadget 2021-05-08 0:08 ` [PATCH v2 3/8] dir: avoid unnecessary traversal into ignored directory Elijah Newren via GitGitGadget 2021-05-08 0:08 ` [PATCH v2 4/8] dir: traverse into untracked directories if they may have ignored subfiles Elijah Newren via GitGitGadget 2021-05-08 0:08 ` [PATCH v2 5/8] [RFC] ls-files: error out on -i unless -o or -c are specified Elijah Newren via GitGitGadget 2021-05-08 0:08 ` [PATCH v2 6/8] dir: update stale description of treat_directory() Derrick Stolee via GitGitGadget 2021-05-08 0:08 ` [PATCH v2 7/8] [RFC] dir: convert trace calls to trace2 equivalents Elijah Newren via GitGitGadget 2021-05-08 0:08 ` [PATCH v2 8/8] [RFC] dir: reported number of visited directories and paths with trace2 Elijah Newren via GitGitGadget 2021-05-08 19:58 ` [PATCH v3 0/8] Directory traversal fixes Elijah Newren via GitGitGadget 2021-05-08 19:58 ` [PATCH v3 1/8] [RFC] dir: convert trace calls to trace2 equivalents Elijah Newren via GitGitGadget 2021-05-10 4:49 ` Junio C Hamano 2021-05-11 17:23 ` Elijah Newren 2021-05-11 16:17 ` Jeff Hostetler 2021-05-11 17:29 ` Elijah Newren 2021-05-08 19:58 ` [PATCH v3 2/8] [RFC] dir: report number of visited directories and paths with trace2 Elijah Newren via GitGitGadget 2021-05-10 5:00 ` Junio C Hamano 2021-05-08 19:58 ` [PATCH v3 3/8] [RFC] ls-files: error out on -i unless -o or -c are specified Elijah Newren via GitGitGadget 2021-05-10 5:09 ` Junio C Hamano 2021-05-11 17:40 ` Elijah Newren 2021-05-11 22:32 ` Junio C Hamano 2021-05-08 19:59 ` [PATCH v3 4/8] t7300: add testcase showing unnecessary traversal into ignored directory Elijah Newren via GitGitGadget 2021-05-10 5:28 ` Junio C Hamano 2021-05-11 17:45 ` Elijah Newren 2021-05-11 22:43 ` Junio C Hamano 2021-05-12 2:07 ` Elijah Newren 2021-05-12 3:17 ` Junio C Hamano 2021-05-08 19:59 ` [PATCH v3 5/8] t3001, t7300: add testcase showcasing missed directory traversal Elijah Newren via GitGitGadget 2021-05-08 19:59 ` [PATCH v3 6/8] dir: avoid unnecessary traversal into ignored directory Elijah Newren via GitGitGadget 2021-05-10 5:48 ` Junio C Hamano 2021-05-11 17:57 ` Elijah Newren 2021-05-08 19:59 ` [PATCH v3 7/8] dir: traverse into untracked directories if they may have ignored subfiles Elijah Newren via GitGitGadget 2021-05-08 19:59 ` [PATCH v3 8/8] dir: update stale description of treat_directory() Derrick Stolee via GitGitGadget 2021-05-11 18:34 ` [PATCH v4 0/8] Directory traversal fixes Elijah Newren via GitGitGadget 2021-05-11 18:34 ` [PATCH v4 1/8] dir: convert trace calls to trace2 equivalents Elijah Newren via GitGitGadget 2021-05-11 19:06 ` Jeff Hostetler 2021-05-11 20:12 ` Elijah Newren 2021-05-11 23:12 ` Jeff Hostetler 2021-05-12 0:44 ` Elijah Newren 2021-05-12 12:26 ` Jeff Hostetler 2021-05-12 15:24 ` Elijah Newren 2021-05-11 18:34 ` [PATCH v4 2/8] dir: report number of visited directories and paths with trace2 Elijah Newren via GitGitGadget 2021-05-11 18:34 ` [PATCH v4 3/8] ls-files: error out on -i unless -o or -c are specified Elijah Newren via GitGitGadget 2021-05-11 18:34 ` [PATCH v4 4/8] t7300: add testcase showing unnecessary traversal into ignored directory Elijah Newren via GitGitGadget 2021-05-11 18:34 ` [PATCH v4 5/8] t3001, t7300: add testcase showcasing missed directory traversal Elijah Newren via GitGitGadget 2021-05-11 18:34 ` [PATCH v4 6/8] dir: avoid unnecessary traversal into ignored directory Elijah Newren via GitGitGadget 2021-05-11 18:34 ` [PATCH v4 7/8] dir: traverse into untracked directories if they may have ignored subfiles Elijah Newren via GitGitGadget 2021-05-11 18:34 ` [PATCH v4 8/8] dir: update stale description of treat_directory() Derrick Stolee via GitGitGadget 2021-05-12 17:28 ` [PATCH v5 0/9] Directory traversal fixes Elijah Newren via GitGitGadget 2021-05-12 17:28 ` [PATCH v5 1/9] dir: convert trace calls to trace2 equivalents Elijah Newren via GitGitGadget 2021-05-12 17:28 ` [PATCH v5 2/9] dir: report number of visited directories and paths with trace2 Elijah Newren via GitGitGadget 2021-05-12 17:28 ` [PATCH v5 3/9] ls-files: error out on -i unless -o or -c are specified Elijah Newren via GitGitGadget 2021-05-12 17:28 ` [PATCH v5 4/9] t7300: add testcase showing unnecessary traversal into ignored directory Elijah Newren via GitGitGadget 2021-05-12 17:28 ` [PATCH v5 5/9] t3001, t7300: add testcase showcasing missed directory traversal Elijah Newren via GitGitGadget 2021-05-12 17:28 ` [PATCH v5 6/9] dir: avoid unnecessary traversal into ignored directory Elijah Newren via GitGitGadget 2021-05-12 17:28 ` [PATCH v5 7/9] dir: traverse into untracked directories if they may have ignored subfiles Elijah Newren via GitGitGadget 2021-05-12 17:28 ` [PATCH v5 8/9] dir: update stale description of treat_directory() Derrick Stolee via GitGitGadget 2021-05-17 17:20 ` Derrick Stolee 2021-05-17 19:44 ` Junio C Hamano 2021-05-18 3:32 ` Elijah Newren 2021-05-19 1:44 ` Junio C Hamano 2021-05-12 17:28 ` [PATCH v5 9/9] dir: introduce readdir_skip_dot_and_dotdot() helper Elijah Newren via GitGitGadget 2021-05-17 17:22 ` Derrick Stolee 2021-05-18 3:34 ` Elijah Newren 2021-05-17 17:23 ` [PATCH v5 0/9] Directory traversal fixes Derrick Stolee
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CABPp-BE4ccB3cVXMqQ-4ZPn6TrRMrD61zHrXNbtNR9GQ9id98Q@mail.gmail.com \ --to=newren@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitgitgadget@gmail.com \ --cc=peff@peff.net \ --cc=sunshine@sunshineco.com \ --subject='Re: [PATCH 1/5] t7300: add testcase showing unnecessary traversal into ignored directory' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).