git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elijah Newren <newren@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Lessley Dennington <lessleydennington@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Derrick Stolee <stolee@gmail.com>
Subject: Re: Bug report - sparse-checkout ignores prefix when run in subdirectories
Date: Wed, 5 Jan 2022 17:08:43 -0800	[thread overview]
Message-ID: <CABPp-BF=-1aZd=nFHF6spo7Ksa7f7Wb7ervCt0QvtNitMY=ZBA@mail.gmail.com> (raw)
In-Reply-To: <xmqq7dbdg1k6.fsf@gitster.g>

On Wed, Jan 5, 2022 at 4:17 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Elijah Newren <newren@gmail.com> writes:
>
> > Are you possibly confusing pathspecs with gitignore patterns here?
> > (Or am I?)  Or are you suggesting that sparse-checkout be modified to
> > accept either gitignore-style files or pathspecs and handle both?
>
> Much closer to the latter (actually, removing ignore patterns, and
> make the subsystem work with pathspecs).

Oh, interesting.  That'd at least suggest you're also happy to get rid
of the ignore patterns in this subsystem if we find a feasible
transition plan to do so.  I'll keep that in mind.  :-)

> > I have never liked that gitignore-style patterns were used for
> > sparse-checkout, but it has always seemed a bit too late to change it.
>
> Perhaps.
>
> > Ever since Stolee introduced cone-mode, my preferred strategy for
> > fixing the gitignore-style patterns problem, assuming we are allowed
> > to do so, is to deprecate if not kill non-cone mode.  (And in the
> > meantime, I'm just doing due diligence when I mention non-cone mode in
> > my reviews.)

  reply	other threads:[~2022-01-06  1:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05 20:13 Lessley Dennington
2022-01-05 22:38 ` Junio C Hamano
2022-01-05 23:19   ` Elijah Newren
2022-01-05 23:29     ` Junio C Hamano
2022-01-06  0:08       ` Elijah Newren
2022-01-06  0:17         ` Junio C Hamano
2022-01-06  1:08           ` Elijah Newren [this message]
2022-01-06 19:25             ` Junio C Hamano
2022-01-27 16:43     ` Derrick Stolee
2022-01-27 17:30       ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABPp-BF=-1aZd=nFHF6spo7Ksa7f7Wb7ervCt0QvtNitMY=ZBA@mail.gmail.com' \
    --to=newren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=lessleydennington@gmail.com \
    --cc=stolee@gmail.com \
    --subject='Re: Bug report - sparse-checkout ignores prefix when run in subdirectories' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).