From: Elijah Newren <newren@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Taylor Blau <me@ttaylorr.com>, Derrick Stolee <stolee@gmail.com>
Subject: Re: What's cooking in git.git (Jan 2021, #04; Sat, 16)
Date: Thu, 21 Jan 2021 08:25:33 -0800 [thread overview]
Message-ID: <CABPp-BGHpvmx-hdZ==MdODKEDVTr92m3rs4T2d_w9Aa0d0zanQ@mail.gmail.com> (raw)
In-Reply-To: <xmqq8s8so84r.fsf@gitster.c.googlers.com>
Hi Junio,
On Sat, Jan 16, 2021 at 2:02 PM Junio C Hamano <gitster@pobox.com> wrote:
> * en/merge-ort-perf (2021-01-15) 4 commits
> - merge-ort: begin performance work; instrument with trace2_region_* calls
> - Merge branch 'en/ort-directory-rename' into en/merge-ort-perf
> - Merge branch 'en/ort-conflict-handling' into en/merge-ort-perf
> - Merge branch 'en/diffcore-rename' into en/merge-ort-perf
> (this branch uses en/diffcore-rename, en/merge-ort-3, en/ort-conflict-handling and en/ort-directory-rename.)
Any chance we could merge this down to next now? In terms of pre-requisites:
* you merged en/diffcore-rename and en/merge-ort-3 to next already
(and marked both as "Will merge to master")
* you previously labelled en/ort-conflict-handling as "Will merge to
next" (and it was reviewed by Stolee[1])
* en/ort-directory-rename has now been reviewed by Taylor[2]
Also, en/merge-ort-perf itself has also been reviewed by Taylor[3].
I have multiple series of patches for performance, starting with a
2-patch series, where for both commit messages and cover letters I
want to use paragraphs of the form:
"""
For the testcases mentioned in commit ??????????
("merge-ort: begin performance work; instrument with trace2_region_*
calls", 2020-10-28), the changes in just this series improves the
performance as follows:
Before Series After Series
no-renames: 12.975 s ± 0.037 s 12.878 s ± 0.050 s
mega-renames: 5154.338 s ± 19.139 s 1673.551 s ± 4.586 s
just-one-mega: 146.703 s ± 0.852 s 47.698 s ± 0.221 s
"""
But I'd like a stable commit identifier to place in the '??????????'
slot, and I think the current round of the series you pushed out last
night and using commit 36d1f87d05 seems like a good such label.
However, since I have so many paragraphs of this form and I don't want
the labels to go stale, it'd be nice if we could merge
en/merge-ort-perf down to at least next first.
[1] https://lore.kernel.org/git/5f6d5428-36ce-3e91-4916-8968ac1b8686@gmail.com/
[2] https://lore.kernel.org/git/YAdh1XTvDhRzGTiC@nand.local/
[3] https://lore.kernel.org/git/X%2FjHpZlSxwAxoUyq@nand.local/ (note
that the series only has one patch)
next prev parent reply other threads:[~2021-01-21 16:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 21:59 What's cooking in git.git (Jan 2021, #04; Sat, 16) Junio C Hamano
2021-01-21 16:25 ` Elijah Newren [this message]
2021-01-21 18:35 ` Junio C Hamano
2021-01-24 5:27 ` Elijah Newren
2021-01-24 7:03 ` Junio C Hamano
2021-01-24 7:10 ` Elijah Newren
2021-01-21 18:34 ` Jonathan Tan
2021-01-21 21:05 ` Jeff King
2021-01-21 23:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPp-BGHpvmx-hdZ==MdODKEDVTr92m3rs4T2d_w9Aa0d0zanQ@mail.gmail.com' \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).