git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elijah Newren <newren@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
	Jason Gore <Jason.Gore@microsoft.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Git clean enumerates ignored directories (since 2.27)
Date: Thu, 6 May 2021 19:31:40 -0700	[thread overview]
Message-ID: <CABPp-BH3tbTyA9gj=2vb878d1MQVCTqT7=kS5U+sB6CoDX0Jww@mail.gmail.com> (raw)
In-Reply-To: <YHf+m7vOQumdJXwX@coredump.intra.peff.net>

On Thu, Apr 15, 2021 at 1:51 AM Jeff King <peff@peff.net> wrote:
>
> On Wed, Apr 14, 2021 at 10:56:14PM +0000, brian m. carlson wrote:
>
> > ----
> > #!/bin/sh
> >
> > git init test-repo
> > cd test-repo
> > longname="directory"
> > touch "$longname.txt"
> > last=400
> > for x in $(seq 1 $last); do
> >   mkdir "x$longname$x"
> >   mv directory* "x$longname$x"
> >   mv "x$longname$x" "$longname$x"
> > done
> > git clean -ffdxn -e directory$last
> > ----
> >
> > When it fails, it will complain that it wasn't able to open the
> > directory.  It still exits zero, however.
> >
> > I haven't bisected this, so I don't know if those patches are related to
> > the problem or not.  I'm a little short on time today to investigate
> > further, but hopefully this can get someone on the right path with a
> > modified version and git bisect run if nothing else.
>
> It bisects to 8d92fb2927 (dir: replace exponential algorithm with a
> linear one, 2020-04-01). I won't pretend to understand everything going
> on in that commit, though.

I've got a patch series to fix this and another traversal problem, and
the tests pass on all platforms.  Wahoo!

BUT!

On alpine linux-musl, I get an "error: Tests passed but test cleanup
failed; aborting", which makes it report as a failed build.  I'm not
sure how to fix it and am asking for ideas.

Apparently the deeply nested directory hierarchy cannot be removed on
that platform with a simple "rm -rf $dirname".  It throws a "rm: can't
stat '/__w/git/git/t/trash
directory.t7300-clean/avoid-traversing-deep-hierarchy/directory400/directory399/directory398/.....(you
get the idea)....': Filename too long" error message.[1]

Adding a "test_when_finished find directory400 -delete" also gives a
"Filename too long" message followed by a lot of "Directory not empty"
messages.[2]

Anyone have any bright ideas about how to tweak this test?  See [3]
for the current incarnation of the code, which was basically taken
from Brian's sample testcase.

[1] https://github.com/git/git/pull/1020/checks?check_run_id=2523414561
[2] https://github.com/git/git/pull/1020/checks?check_run_id=2523594095
[3] https://github.com/git/git/pull/1020

  parent reply	other threads:[~2021-05-07  2:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14 17:17 Jason Gore
2021-04-14 22:56 ` brian m. carlson
2021-04-15  8:51   ` Jeff King
2021-04-22 17:18     ` Jason Gore
2021-04-22 17:24       ` Elijah Newren
2021-05-07  4:08       ` Elijah Newren
2021-05-07  2:31     ` Elijah Newren [this message]
2021-05-07  3:25       ` Jeff King
2021-05-07  3:43         ` Jeff King
2021-05-07  3:44         ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABPp-BH3tbTyA9gj=2vb878d1MQVCTqT7=kS5U+sB6CoDX0Jww@mail.gmail.com' \
    --to=newren@gmail.com \
    --cc=Jason.Gore@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    --subject='Re: Git clean enumerates ignored directories (since 2.27)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).