From: Phil Hord <phil.hord@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, congdanhqx@gmail.com, plavarre@purestorage.com
Subject: Re: [PATCH] date.c: allow ISO 8601 reduced precision times
Date: Mon, 9 Jan 2023 10:30:10 -0800 [thread overview]
Message-ID: <CABURp0oAuT702PfFppir-u9psOt0ETDXeO+_8TwB5UO-edoaKw@mail.gmail.com> (raw)
In-Reply-To: <xmqqy1qct6e8.fsf@gitster.g>
On Mon, Jan 9, 2023 at 1:16 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> Junio C Hamano <gitster@pobox.com> writes:
>
> > Phil Hord <phil.hord@gmail.com> writes:
> >
> >> Do you have any suggestions about how I can better alleviate your
> >> concerns? I don't think there are real regressions here and I tried
> >> to explain why.
> >
> > Other than "including it in a released version and waiting for
> > people to scream", I do not think there is. The "next" branch was
> > meant to be a test ground for these new features by letting
> > volunteer users to use it in their everyday development, and the
> > hope was that we can catch regressions by cooking risky topics
> > longer than usual in there, but we haven't been very successful, I
> > have to say.
> >
> > Thanks. Let's queue it and see what happens.
>
> Actually, let's not queue it as-is, because it seems to break many
> tests for me. I won't have time to take further look myself before
> later in the week when I come back online again, though.
Oh, wow. For me as well. I thought I ran all the tests before
finishing up, but I guess I was too focused on the single test module.
I apologize for the oversight.
next prev parent reply other threads:[~2023-01-09 18:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 3:36 [PATCH] date.c: allow ISO 8601 reduced precision times Phil Hord
2022-12-16 4:23 ` Junio C Hamano
2022-12-16 18:38 ` Phil Hord
2023-01-09 6:41 ` Phil Hord
2023-01-09 8:48 ` Junio C Hamano
2023-01-09 9:16 ` Junio C Hamano
2023-01-09 18:30 ` Phil Hord [this message]
2023-01-09 11:29 ` [PATCH] fixup! " Đoàn Trần Công Danh
2023-01-09 12:29 ` [PATCH] date.c: limit less precision ISO-8601 with its marker Đoàn Trần Công Danh
2023-01-09 18:57 ` Phil Hord
2023-01-11 0:10 ` [PATCH v2] date.c: allow ISO 8601 reduced precision times Đoàn Trần Công Danh
2023-01-13 19:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABURp0oAuT702PfFppir-u9psOt0ETDXeO+_8TwB5UO-edoaKw@mail.gmail.com \
--to=phil.hord@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=plavarre@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).