From: Phil Hord <phil.hord@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Jens Lehmann <Jens.Lehmann@web.de>,
Heiko Voigt <hvoigt@hvoigt.net>
Subject: Re: Zsh submodule name completion borked
Date: Fri, 2 May 2014 12:23:02 -0400 [thread overview]
Message-ID: <CABURp0qdd6LYVfF0g8BWo_xjK36LbS=EnXkF_Kb4XQPM8U9r_g@mail.gmail.com> (raw)
In-Reply-To: <5362cc42ed06d_569a13852ecb@nysa.notmuch>
On Thu, May 1, 2014 at 6:35 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> Phil Hord wrote:
>> When I use zsh tab-completion to complete the submodule name in 'git
>> submodule init', I get more than I expected.
>>
>> From the gerrit repository (which has plugins):
>> $ git submodule init plugins/<TAB>
>> plugins/commit-message-length-validator\ \(v1.0-rc1-9-g545000b\)
>> plugins/reviewnotes\ \(v1.0-rc1-8-ge984300\)
>> plugins/replication\ \(v1.1-rc0-13-g4c3f4c9\)
>>
>> It works ok in bash. I tried to bisect the trouble, but it still
>> fails in 1.8.3, so I'm beginning to think it's me. Does this happen
>> to anyone else? Is it something in my local configuration causing
>> this?
>
It seems to be something local. I thought the issue persisted with no
local .zshrc config, but it looks like I only turned off my local
config and not the global settings. The recent Ubuntu update is a
likely culprit. I'll investigate locally and turn my reports up to
Ubuntu/Debian/Zshell.
> Define 'works' in bash. From what I can see from the bash completion,
> it's not doing anything special, so the completion you see are simply
> files.
To clarify my description in case anyone else sees it or is
interested, before I load /etc/zsh/zshrc, tab gives me simple filename
expansion.
After I load /etc/zsh/zshrc, tab expands only submodules in HEAD. But
for some reason it gets the wrong kind of results in the expansion,
returning not just submodule paths, but submodule paths with tag info
appended.
Sample session:
$ zsh --norcs
% git submodule init plugins/<TAB>
commit-message-length-validator/
README
reviewnotes/
replication/
^C
% source /etc/zsh/zshrc
% git submodule init plugins/<TAB>
plugins/commit-message-length-validator\ \(v1.0-rc1-9-g545000b\)
plugins/reviewnotes\ \(v1.0-rc1-8-ge984300\)
plugins/replication\ \(v1.1-rc0-13-g4c3f4c9\)
prev parent reply other threads:[~2014-05-02 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 22:23 Zsh submodule name completion borked Phil Hord
2014-05-01 22:31 ` Jonathan Nieder
2014-05-01 22:35 ` Felipe Contreras
2014-05-02 16:23 ` Phil Hord [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABURp0qdd6LYVfF0g8BWo_xjK36LbS=EnXkF_Kb4XQPM8U9r_g@mail.gmail.com' \
--to=phil.hord@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).