Re: [PATCH 1/8] Import $LS_COLORS parsing code from coreutils

[Duy Nguyen <pclouds@gmail.com>]

On Fri, Mar 21, 2014 at 2:09 AM, David Tran <unsignedzero@gmail.com> wrote:
> Nguyễn Thái Ngọc Duy <pclouds <at> gmail.com> writes:
>
>> This could could help highlight files in ls-files or status output, or
>> even diff --name-only (but that's questionable).
>>
>> This code is from coreutils.git commit
>> 7326d1f1a67edf21947ae98194f98c38b6e9e527 file src/ls.c. This is the
>> last GPL-2 commit before coreutils turns to GPL-3.
>>
>
> I don't know if this is something to consider but for my mac, I have another
> variable CLICOLOR which shows the colors if it is set. This is also true with
> FreeBSD[1] as well. I don't know if that should be checked if you're on those
> systems.
>
> I think it would be nice to have --color flag as well if you want to enable
> color output for just that one output.

My plan is stick to how git handles colors (e.g. --color and color.*
config variables). Is that enough or do you think git CLICOLOR should
override --color and color.*?

>
> [1]: https://unix.stackexchange.com/questions/2897/clicolor-and-ls-colors-in-
> bash
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Duy