From: Duy Nguyen <pclouds@gmail.com>
To: Christophe Bliard <christophe.bliard@trux.info>
Cc: Git Mailing List <git@vger.kernel.org>,
Rafael Ascensao <rafa.almas@gmail.com>
Subject: Re: bug?: git grep HEAD with exclude in pathspec not taken into account
Date: Sat, 27 Oct 2018 16:57:14 +0200 [thread overview]
Message-ID: <CACsJy8A83_Jh4GmVYXS-zk_6Yro6eeB9i_J7xh3VMTkr8JVDvA@mail.gmail.com> (raw)
In-Reply-To: <CAGOLd-5Gbt6fQTvm+7018uX+8WF7NUWpa1sFWAg3-5bxtmOt-Q@mail.gmail.com>
On Wed, Oct 24, 2018 at 4:55 PM Christophe Bliard
<christophe.bliard@trux.info> wrote:
>
> Hi,
>
> I observed an unexpected behavior while using git grep with both git
> 2.19.1 and 2.14.3.
Quick note. I confirm this is a bug in tree_entry_interesting()
perhaps being over-optimistic. It'll take me more time to familiarize
myself with this negative matching in the function before I come up
with a fix for it. Thanks for reporting.
--
Duy
next prev parent reply other threads:[~2018-10-27 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAGOLd-7Hi+tssj4ozKPd04squ-PuFwtt6f2nhbZp-zKwy62pVQ@mail.gmail.com>
2018-10-24 14:53 ` bug?: git grep HEAD with exclude in pathspec not taken into account Christophe Bliard
2018-10-24 15:14 ` Duy Nguyen
2018-10-24 15:39 ` Christophe Bliard
2018-10-27 14:57 ` Duy Nguyen [this message]
2018-11-03 15:30 ` [PATCH] tree-walk.c: fix overoptimistic inclusion in :(exclude) matching Nguyễn Thái Ngọc Duy
2018-11-04 0:25 ` Eric Sunshine
2018-11-04 6:27 ` Eric Sunshine
2018-11-04 6:29 ` Duy Nguyen
2018-11-04 5:28 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2018-11-05 1:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8A83_Jh4GmVYXS-zk_6Yro6eeB9i_J7xh3VMTkr8JVDvA@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=christophe.bliard@trux.info \
--cc=git@vger.kernel.org \
--cc=rafa.almas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).