From: Duy Nguyen <pclouds@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Josh Triplett <josh@joshtriplett.org>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: gc and repack ignore .git/*HEAD when checking reachability
Date: Sun, 10 Jul 2016 17:01:52 +0200 [thread overview]
Message-ID: <CACsJy8AFYWsi1_f-Hw1odN3gmbfqayXuoBHo+K3Fh4XBwMA0Vw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1607101602320.6426@virtualbox>
On Sun, Jul 10, 2016 at 4:16 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>> No, the point is, refs subsystem needs to know which refs is per-repo,
>> which is per-worktree. So far the rules are "everything under refs,
>> except a few known exceptions, is per-repo" and "everything directly
>> under $GIT_DIR is per-worktree", which work fine. But if you allow to
>> move per-worktree to "refs" freely, then the "known exceptions" will
>> have to be updated every time a new per-worktree ref appears. It'll be
>> easier to modify the first rule as "everything under refs, except some
>> legacy exceptions and refs/worktree, is per-repo".
>
> Given the substantial pain and suffering I have due to per-worktree
> reflogs (and those are *just* HEAD's reflogs!),
I apologize for that. I clearly did not see all the consequences of my
simple-minded approach. Watch out for the shared config issue too if
you start to rely on multiple worktrees. It may take even longer time
to address than this one.
> it appears to me that per-worktree refs would be a particularly poor feature.
>
> I agree that HEAD needs to be per-worktree, but already the fact that the
> HEADs of the worktrees, along with their reflogs, are *not* visible to
> all other worktrees causes substantial trouble.
>
> In my mind, a much more natural design would have been to map
> transparently each worktree's HEAD to refs/worktree/<name>/HEAD *and keep
> those refs and reflogs visible across all worktrees*.
We will be able to see refs from all worktrees if we choose to. There
is no question about that. It's needed for full-repo operations, gc
included. Whether we expose all worktree namespaces via refs/worktree
(as a logical view, not storage one), remains to be seen. Michael's
new ref API may be flexible enough that we could do without. I'm not
sure yet.
> With that design, I would not have irretrievably lost reflogs to auto-gc
> nor dozens of hours trying to figure out how to have *any* auto-gc succeed
> again (because I need to reduce the horrible slowness incurred by too many
> loose objects). My interactive rebases would also not have started to
> print the auto-gc error after every friggin' pick.
--
Duy
next prev parent reply other threads:[~2016-07-10 15:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 2:59 gc and repack ignore .git/*HEAD when checking reachability Josh Triplett
2016-07-08 4:34 ` Junio C Hamano
2016-07-08 6:44 ` Josh Triplett
2016-07-08 17:14 ` Junio C Hamano
2016-07-08 19:25 ` Theodore Ts'o
2016-07-08 20:30 ` Junio C Hamano
2016-07-08 23:50 ` Theodore Ts'o
2016-07-09 5:23 ` Josh Triplett
2016-07-08 20:29 ` Josh Triplett
2016-07-09 7:35 ` Johannes Schindelin
2016-07-09 14:09 ` Josh Triplett
2016-07-09 16:45 ` Duy Nguyen
2016-07-10 10:59 ` Johannes Schindelin
2016-07-10 11:04 ` Duy Nguyen
2016-07-10 14:16 ` Johannes Schindelin
2016-07-10 15:01 ` Duy Nguyen [this message]
2016-07-11 6:07 ` Johannes Schindelin
2016-07-11 18:52 ` Junio C Hamano
2016-07-12 10:47 ` Johannes Schindelin
2016-07-12 15:26 ` Jeff King
2016-07-12 15:46 ` Duy Nguyen
2016-07-12 15:51 ` Jeff King
2016-07-12 16:13 ` Duy Nguyen
2016-07-13 8:20 ` Johannes Schindelin
2016-07-13 14:54 ` Duy Nguyen
2016-07-13 18:59 ` Johannes Schindelin
2016-07-15 15:46 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8AFYWsi1_f-Hw1odN3gmbfqayXuoBHo+K3Fh4XBwMA0Vw@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=josh@joshtriplett.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).