From: Duy Nguyen <pclouds@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: jn.avila@free.fr, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] i18n: fix dangling dot in die() messages
Date: Tue, 4 Sep 2018 17:16:05 +0200 [thread overview]
Message-ID: <CACsJy8CgS1JzbKhV4T+xpCHnc8OrVEd5i-o-O-XamPxuPOZjMw@mail.gmail.com> (raw)
In-Reply-To: <CACBZZX6Bm-xOO-mvDzmRAA9Xu6HrBr5z+39dp4t6fTTCmNHKbQ@mail.gmail.com>
On Tue, Sep 4, 2018 at 5:08 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>
> On Tue, Sep 4, 2018 at 4:59 PM Jean-Noel Avila <jn.avila@free.fr> wrote:
>
> Your commit message says "dangling dot"...
>
> > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> > index b56028ba9d..a011abfd7c 100644
> > --- a/builtin/submodule--helper.c
> > +++ b/builtin/submodule--helper.c
> > @@ -521,7 +521,7 @@ static void runcommand_in_submodule_cb(const struct cache_entry *list_item,
> > printf(_("Entering '%s'\n"), displaypath);
> >
> > if (info->argv[0] && run_command(&cp))
> > - die(_("run_command returned non-zero status for %s\n."),
> > + die(_("run_command returned non-zero status for %s"),
>
> ...but here and below you're also removing the newline. Is this
> intended, and does it work as desired afterwards? I.e. were we just
> ignoring the \n?
die() already adds \n, so this \n adds a blank line. Since this is an
error, not part of any fancy text layout construction, I think the \n
here could (and should) be removed
--
Duy
next prev parent reply other threads:[~2018-09-04 15:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 21:00 [PATCH] i18n: fix mistakes in translated strings Jean-Noël Avila
2018-08-23 21:28 ` Junio C Hamano
2018-09-03 17:52 ` Jean-Noël AVILA
2018-09-04 1:01 ` [L10N] Kickoff for Git 2.19.0 round 2 Jiang Xin
2018-09-04 1:52 ` [PATCH] i18n: fix mistakes in translated strings Jiang Xin
2018-09-04 14:18 ` [PATCH] i18n: fix dangling dot in die() messages Jean-Noel Avila
2018-09-04 15:05 ` Ævar Arnfjörð Bjarmason
2018-09-04 15:13 ` Jean-Noël Avila
2018-09-04 19:47 ` Junio C Hamano
2018-09-04 15:16 ` Duy Nguyen [this message]
2018-09-04 19:32 ` [PATCH] i18n: fix mistakes in translated strings Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8CgS1JzbKhV4T+xpCHnc8OrVEd5i-o-O-XamPxuPOZjMw@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jn.avila@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).