git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: "Robin H. Johnson" <robbat2@gentoo.org>
Cc: Git Mailing List <git@vger.kernel.org>,
	Prathamesh Chavan <pc44800@gmail.com>
Subject: Re: regression AGAIN in output of git-pull --rebase --recurse-submodules=yes --quiet
Date: Fri, 12 Apr 2019 16:25:34 +0700	[thread overview]
Message-ID: <CACsJy8DpFYiWJpRULKXEYFLnNU4Xnz5pNn1DHpb0bJnJrTwN3Q@mail.gmail.com> (raw)
In-Reply-To: <robbat2-20190412T063235-859985527Z@orbis-terrarum.net>

On Fri, Apr 12, 2019 at 2:09 PM Robin H. Johnson <robbat2@gentoo.org> wrote:
> > -- 8< --
> (snip patch, please add my DCO signed-off-by)
> Tested-by: Robin H. Johnson <robbat2@gentoo.org>
> Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
> > -- 8< --
> >
> > I'm a bit reluctant to follow up with a proper patch because I can't
> > digest the t5572-submodule-pull.sh tests. And we definitely need to
> > add a test case about --quiet to make sure it won't happen again.
> Find testcase attached. Please submit in a series with your patch

Clever. I was stuck thinking about actually pulling things. But yeah
"echo --quiet" does the job just as well. Making patches (and maybe
trying to fix that pull --rebase --quiet thing as well)
-- 
Duy

  reply	other threads:[~2019-04-12  9:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-20  5:57 regression in output of git-pull --rebase --recurse-submodules=yes --quiet Robin H. Johnson
2018-01-25 19:08 ` [PATCH] builtin/pull: respect verbosity settings in submodules Stefan Beller
2018-01-25 19:18   ` Junio C Hamano
2019-04-10  6:41 ` regression AGAIN in output of git-pull --rebase --recurse-submodules=yes --quiet Robin H. Johnson
2019-04-10 11:18   ` Duy Nguyen
2019-04-12  7:08     ` Robin H. Johnson
2019-04-12  9:25       ` Duy Nguyen [this message]
2019-04-15 14:40       ` Johannes Schindelin
     [not found]     ` <CAODn77oL6sj5zvxgPGw=4TNqmnSeBq4=j2r2nx_51YHooECo7w@mail.gmail.com>
2019-04-16  7:48       ` Duy Nguyen
2019-04-12 10:08   ` [PATCH] submodule foreach: fix "<command> --quiet" not being respected Nguyễn Thái Ngọc Duy
2019-04-12 17:22     ` Robin H. Johnson
2019-04-15  2:59       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACsJy8DpFYiWJpRULKXEYFLnNU4Xnz5pNn1DHpb0bJnJrTwN3Q@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pc44800@gmail.com \
    --cc=robbat2@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).