git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v2] packfile-uri.txt: fix blobPackfileUri description
@ 2021-05-13  6:44 Teng Long
  0 siblings, 0 replies; 5+ messages in thread
From: Teng Long @ 2021-05-13  6:44 UTC (permalink / raw)
  To: gitster; +Cc: dyroneteng, git, jonathantanmy

Junio C Hamano writes:

>Yes.  Some people seem to omit the final response to reviewer
>suggestions on the previous round and just send a revised patch, but
>it is much nicer to cleanly conclude the review cycle for the
>previous round with a separate response (it could just be "yes,
>you're right---I'll incorporate your suggestions in the next round,
>thanks") before starting a new cycle.

If I  send a new patch cycle, the "--thread"  argument seems
to be recommended. This may be the reason why it is easier
to understand when submitting a series of patches?

I may try to use "--thread", but it may make this whole
patch more confusing, sorry for that.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Optimize the description of the configuration in packfile-uris doc
@ 2021-05-06 21:39 Junio C Hamano
  2021-05-11  6:45 ` [PATCH v2] packfile-uri.txt: fix blobPackfileUri description Teng Long
  0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2021-05-06 21:39 UTC (permalink / raw)
  To: Jonathan Tan; +Cc: dyroneteng, git

Jonathan Tan <jonathantanmy@google.com> writes:

>> There is a description problem in the document about packfile-uris. This
>> patch describes the configuration format of `uploadpack.blobPackfileUri`
>> more accurately.
>
> Thanks for noticing this. The diff itself is correct, of course.
>
> As for the commit message, limit the title to 50 characters or fewer if
> possible. Maybe something like "packfile-uri.txt: fix blobPackfileUri
> description" or something like that.
>
> Also in the commit message, maybe mention that the correct format can be
> seen in t5702.

Thanks for giving a review with clear suggestion for improvements,
Jonathan.  And thanks for contributing, Teng.

Will look forward to seeing an updated patch.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-05-13  6:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13  6:44 [PATCH v2] packfile-uri.txt: fix blobPackfileUri description Teng Long
  -- strict thread matches above, loose matches on Subject: below --
2021-05-06 21:39 [PATCH] Optimize the description of the configuration in packfile-uris doc Junio C Hamano
2021-05-11  6:45 ` [PATCH v2] packfile-uri.txt: fix blobPackfileUri description Teng Long
2021-05-11 20:50   ` Junio C Hamano
2021-05-12 14:10     ` Long Teng
2021-05-12 23:32       ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).