Re: [PATCH 1/2] prepare_packed_git(): refactor garbage reporting in pack directory

From: Doug Kelly <dougk.ff7@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Git List <git@vger.kernel.org>,
	Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH 1/2] prepare_packed_git(): refactor garbage reporting in pack directory
Date: Wed, 13 Jan 2016 14:19:05 -0600	[thread overview]
Message-ID: <CAEtYS8RA2HONEARQ03EiT8Ch+F2am+YJuRz2hNiSGO25N8Lf4g@mail.gmail.com> (raw)
In-Reply-To: <xmqqvb6xmedw.fsf@gitster.mtv.corp.google.com>

On Wed, Jan 13, 2016 at 2:08 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Doug Kelly <dougk.ff7@gmail.com> writes:
>
>> Yeah, I know I never got to adding the mtime logic, but for a simple (naive,
>> hard-coded) case, I did come up with a basic patch today.  I think this could
>> be extended to a configuration option(?) which would allow a default longer
>> than 10 seconds (an hour? a day?), then during the regression tests, we
>> could provide a shorter timeout to ensure the guarding both works and also
>> not wait forever for tests to complete.  Thoughts?
>
> Please do not sleep in the tests.  Instead, please try to see if you
> can use test-chmtime to set the timestamps of these files to the
> necessary ages for the purpose of your tests.
>
> Thanks.

Ah, thanks -- I actually didn't know about that.  I didn't intend this
to be a formal
patch (although I'm sorry the mail client clobbered all the
whitespace), but I will
keep this in mind for when I continue to refine this change.

However, back to the point: should the wait value be hard coded? Configurable
as a new option?  What should our default wait be?

Thanks!