From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7697AC34026 for ; Tue, 18 Feb 2020 09:25:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47AA020658 for ; Tue, 18 Feb 2020 09:25:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vMUIaj5J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726298AbgBRJZg (ORCPT ); Tue, 18 Feb 2020 04:25:36 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:54640 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbgBRJZg (ORCPT ); Tue, 18 Feb 2020 04:25:36 -0500 Received: by mail-wm1-f67.google.com with SMTP id g1so1980734wmh.4 for ; Tue, 18 Feb 2020 01:25:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=whXq1vWQsIJ5SYzoRx7AyojRhB0CogjeauR+o6SC2Lc=; b=vMUIaj5JIb5Y/wdnu5BVx46w+giByh45cLMEqylRf8dWbGKhwcFFmmvg8VWOeFr9HL m0n9AQzQ+FLwYU4VtPHQA+CT/aOraySWo5EJZxEMQJtapq5EJewoUcQ6R1pJ5j3PkloQ hG5fBFlJeDa8QTDXFWkBSL0fFhur7SGpsV0pmZ2tmS3IGkxat3dTkfz6RBoQIwvNOQO6 qxHnW2QYDvUyLWo1rj1L1O5sbuQ2zu9yjGZ9+YK3g/EYUyhR6zoklgfdjExAVaZhOVxi eL4sSgNR+zRi+8pA3WigkGpH6xNA8BcHxZTgpCBQqb6Xvy8RacNPsjUzua3k6cpYE4lF FAxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=whXq1vWQsIJ5SYzoRx7AyojRhB0CogjeauR+o6SC2Lc=; b=n73GL66o6Wu0wdCR7OllOq1mj4XAAbSYVgQPERHEle1eShQO/OWGGg73IVrd4Dyfsb EXAYWe7phIRRdS8D8F1z1NSXV+jERkcFtHfSLcmHfdhN5PujiH7cWOAxre1vmeKhknvj WtLNfMx6ArD7qf82EOmP+iS2jFP9cm6HVbr9FqO/NbZKSVLxxDKBLi1J6XSYC2GeRFUK L9D/bJBlXX2sVOulv3Ah8xAnb0HAEaqa49DXn5x1GSRHZmOOF1jMPriHrGTdUlymuohb H0e41ZXQ9W5bq0RaWj5re9lxmbOjPI/NMejnJXGYmRowSswerTEPAR+pt8211nh27OG4 p7Mw== X-Gm-Message-State: APjAAAXzwvrqBhcp6Tz1XeJPnI30A5yDTPW2+e6eWz2dFIkCcsyRE97E O6RgGen4apv/XBGOWqsIRLPkH0wW4YmnZ8RVjw5fOg== X-Google-Smtp-Source: APXvYqw1cOKk4QAcLiynYX+fD101neC8KUfzkkLrqNuun642INZDfWbpYdDSKFEMWVNZSg1uaDrUu5GePDjf0ScUqTo= X-Received: by 2002:a05:600c:145:: with SMTP id w5mr1926804wmm.157.1582017933616; Tue, 18 Feb 2020 01:25:33 -0800 (PST) MIME-Version: 1.0 References: <02d2ca8b878a67a3334b222725645dd035b4289c.1581029756.git.gitgitgadget@gmail.com> <20200207001612.GF6573@camp.crustytoothpaste.net> <20200211000520.GA6454@camp.crustytoothpaste.net> <20200211234000.GA6464@camp.crustytoothpaste.net> In-Reply-To: <20200211234000.GA6464@camp.crustytoothpaste.net> From: Han-Wen Nienhuys Date: Tue, 18 Feb 2020 10:25:20 +0100 Message-ID: Subject: Re: [PATCH v4 4/5] Add reftable library To: "brian m. carlson" , Han-Wen Nienhuys , Junio C Hamano , Han-Wen Nienhuys via GitGitGadget , git , Han-Wen Nienhuys Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Feb 12, 2020 at 12:40 AM brian m. carlson wrote: > > On 2020-02-11 at 16:40:56, Han-Wen Nienhuys wrote: > > I can see a future where we have a different format that allows for > > more metadata so we can encode the hash size separately. But maybe > > that can be for format v3 and up. > > > > Let's do format v2 =3D format v1 but with 32-byte hashes. > > The way we've preferred to do this in Git is to write a four-byte hash > identifier into the file, but we have legacy concerns here, so I think > switching to v2 for SHA-256 is fine. > -- > brian m. carlson: Houston, Texas, US > OpenPGP: https://keybase.io/bk2204 I've implemented this in the last version of the series. --=20 Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado