git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Han-Wen Nienhuys <hanwen@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Han-Wen Nienhuys via GitGitGadget <gitgitgadget@gmail.com>,
	git <git@vger.kernel.org>, Han-Wen Nienhuys <hanwenn@gmail.com>
Subject: Re: [PATCH v2] refs: make explicit that ref_iterator_peel returns boolean
Date: Thu, 20 May 2021 11:04:20 +0200	[thread overview]
Message-ID: <CAFQ2z_OUxrW_m5H_y62=Q_i0Kj3c4=2Kzf4hRwVwp-wGPcGayw@mail.gmail.com> (raw)
In-Reply-To: <xmqqzgwqwcu1.fsf@gitster.g>

On Thu, May 20, 2021 at 12:58 AM Junio C Hamano <gitster@pobox.com> wrote:
> > Use -1 as error return value throughout.
>
> So this corresponds to the bottommost step in the series that is
> queued as hn/reftable, with the difference at the end of this
> message.
>
> Do you want me to replace that single step with this version and
> rebuild the remainder of the topic on top?

Yes.

I'm hoping this can graduate soon, so the hn/reftable topic becomes
smaller (I don't know what that means for your organization of the
seen branch).

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

  reply	other threads:[~2021-05-20  9:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 11:02 [PATCH] refs: ref_iterator_peel returns boolean, rather than peel_status Han-Wen Nienhuys via GitGitGadget
2021-05-19 15:31 ` [PATCH v2] refs: make explicit that ref_iterator_peel returns boolean Han-Wen Nienhuys via GitGitGadget
2021-05-19 22:58   ` Junio C Hamano
2021-05-20  9:04     ` Han-Wen Nienhuys [this message]
2021-07-06 18:09       ` Han-Wen Nienhuys
2021-07-06 19:54         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFQ2z_OUxrW_m5H_y62=Q_i0Kj3c4=2Kzf4hRwVwp-wGPcGayw@mail.gmail.com' \
    --to=hanwen@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=hanwenn@gmail.com \
    --subject='Re: [PATCH v2] refs: make explicit that ref_iterator_peel returns boolean' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).