From: Alex Netkachov <alex.netkachov@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: Potential bug in pack-objects.c
Date: Tue, 22 Jan 2019 15:33:25 +0000 [thread overview]
Message-ID: <CAGAu0HW=N2nQr7zq_EVpegJDc6_womFDCLU5SCoCQw6cmzw8xg@mail.gmail.com> (raw)
In-Reply-To: <20190122072946.GB28975@sigill.intra.peff.net>
On Tue, 22 Jan 2019 at 07:29, Jeff King <peff@peff.net> wrote:
>
> On Mon, Jan 21, 2019 at 10:10:16PM +0000, Alex Netkachov wrote:
>
> > On the location builtin/pack-objects.c:1996 the code tries to set
> > read_lock (pthread_mutex_lock(&read_mutex)) and fails. I suspect that
> > read_mutex is not initialised yet. It is initialised in
> > init_threaded_search, which is called later in prepare_pack (through
> > ll_find_deltas).
>
> This sounds like the same bug being discussed in:
>
> http://public-inbox.org/git/20190118022736.36832-1-phogg@novamoon.net/
It is exactly the same thing. Thank you. Hope it will be applied soon
and released.
Kind regards,
Alex
prev parent reply other threads:[~2019-01-22 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 22:10 Potential bug in pack-objects.c Alex Netkachov
2019-01-22 7:29 ` Jeff King
2019-01-22 15:33 ` Alex Netkachov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGAu0HW=N2nQr7zq_EVpegJDc6_womFDCLU5SCoCQw6cmzw8xg@mail.gmail.com' \
--to=alex.netkachov@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).