From: Stefan Beller <firstname.lastname@example.org> To: Jeff King <email@example.com> Cc: git <firstname.lastname@example.org>, email@example.com, Junio C Hamano <firstname.lastname@example.org>, Duy Nguyen <email@example.com> Subject: Re: ordered string-list considered harmful, was Re: [PATCH v3] Allow aliases that include other aliases Date: Thu, 6 Sep 2018 13:54:15 -0700 [thread overview] Message-ID: <CAGZ79kbFe8WMswWy+SorYUvEj2r5rUQdjx=zbVK5BfeU+Mgx9A@mail.gmail.com> (raw) In-Reply-To: <20180906204932.GA1482@sigill.intra.peff.net> > > Does a hashmap guarantee an order? > > No, it definitely doesn't. > > I guess the reading-between-the-lines assumption that I didn't quite say > is: I think most (if not all) of the users of sorted string lists don't > actually care about a particular order. They just want efficient lookup. > > > I thought we had an example of an ordered list in the submodule code > > but could not find it, maybe it is gone already or did not rely on the order > > as I thought. > > > > It turns out we make never use of a custom compare function in > > the stringlist, which helps gaining confidence this use case is nowhere > > to be found in the code. > > Plenty of code uses the default strcmp. You can find users which assume > sorting by their use of string_list_insert() versus _append(). Or ones > that call string_list_sort(), of course. Here comes my reading-between-the-lines assumption: When using the default comparison function, you probably only care about the efficient lookup as described above, but if you had a non-default order, then we'd have strong evidence of the contrary as the author of such code would have found reasons why that order is superior than default order (and don't tell me a different order helps making lookups even more efficient, this must be another reason).
next prev parent reply other threads:[~2018-09-06 20:54 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-06 19:12 Jeff King 2018-09-06 19:20 ` Jeff King 2018-09-06 23:50 ` Jonathan Nieder 2018-09-07 3:24 ` Jeff King 2018-09-07 6:32 ` Jonathan Nieder 2018-09-07 7:20 ` Ævar Arnfjörð Bjarmason 2018-09-07 7:23 ` Jonathan Nieder 2018-09-08 16:49 ` brian m. carlson 2018-09-07 14:48 ` Jeff King 2018-09-06 20:04 ` Stefan Beller 2018-09-06 20:49 ` Jeff King 2018-09-06 20:54 ` Stefan Beller [this message] 2018-09-07 3:12 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGZ79kbFe8WMswWy+SorYUvEj2r5rUQdjx=zbVK5BfeU+Mgx9A@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: ordered string-list considered harmful, was Re: [PATCH v3] Allow aliases that include other aliases' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).