git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeffrey Walton <noloader@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>
Subject: Re: git-compat-util.h:798:13: error: conflicting types for ‘inet_ntop’
Date: Mon, 3 Feb 2020 05:46:53 -0500	[thread overview]
Message-ID: <CAH8yC8mmNXGw13zkrmxxJFQKEsmGqkKHFp13+U7==umHM2WR_Q@mail.gmail.com> (raw)
In-Reply-To: <20200203085405.GC2164@coredump.intra.peff.net>

...
> But having those variables unset is already the default. The root of the
> problem is likely that the autoconf test seems to get the wrong result
> on Solaris (another workaround would be to remove them from
> config.mak.autogen, but that will get obliterated next time you run
> ./configure).

Thanks Jeff.

Below is from configure.ac around line 720
(https://github.com/git/git/blob/master/configure.ac#L722).

I think the test program needs to include <arpa/inet.h>. Then, if the
current -lresolv test fails, configure should use the same program and
check -lsocket -lnls.

How would you like to craft the test? Or how should I craft the test?

# The next few tests will define NEEDS_RESOLV if linking with
# libresolv provides some of the functions we would normally get
# from libc.
NEEDS_RESOLV=
#
# Define NO_INET_NTOP if linking with -lresolv is not enough.
# Solaris 2.7 in particular hos inet_ntop in -lresolv.
NO_INET_NTOP=
AC_CHECK_FUNC([inet_ntop],
[],
[AC_CHECK_LIB([resolv], [inet_ntop],
[NEEDS_RESOLV=YesPlease],
[NO_INET_NTOP=YesPlease])
])
GIT_CONF_SUBST([NO_INET_NTOP])

  parent reply	other threads:[~2020-02-03 10:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01 11:39 git-compat-util.h:798:13: error: conflicting types for ‘inet_ntop’ Jeffrey Walton
2020-02-01 12:12 ` Jeffrey Walton
2020-02-01 12:34   ` Jeffrey Walton
2020-02-03  8:54   ` Jeff King
2020-02-03  8:59     ` Jeffrey Walton
2020-02-03 10:01       ` Jeff King
2020-02-03 10:46     ` Jeffrey Walton [this message]
2020-02-03 11:02       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH8yC8mmNXGw13zkrmxxJFQKEsmGqkKHFp13+U7==umHM2WR_Q@mail.gmail.com' \
    --to=noloader@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).