From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Andreas Heiduk" <asheiduk@gmail.com>, git <git@vger.kernel.org>,
"Greg Hurrell" <greg@hurrell.net>, "René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH] grep: follow conventions for printing paths w/ unusual chars
Date: Sun, 19 Apr 2020 03:27:21 -0300 [thread overview]
Message-ID: <CAHd-oW4dkLMp3FYyRoRWVgcTMJ0oKnKfnK--3r_Mx9EfrLoEnQ@mail.gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2004181655300.46@tvgsbejvaqbjf.bet>
Hi, Dscho
On Sat, Apr 18, 2020 at 11:57 AM Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>
> On Sat, 18 Apr 2020, Johannes Schindelin wrote:
> >
> > On Fri, 17 Apr 2020, Matheus Tavares wrote:
...
> > >
> > > Reported-by: Greg Hurrell <greg@hurrell.net>
> > > Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br>
> > > ---
> > > Documentation/git-grep.txt | 6 +++--
> > > builtin/grep.c | 46 ++++++++++++++++++++++++++++----------
> > > t/t7810-grep.sh | 44 ++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 82 insertions(+), 14 deletions(-)
> >
> > Unfortunately, this causes eight test failures on Windows:
> > https://dev.azure.com/gitgitgadget/git/_build/results?buildId=38023&view=ms.vss-test-web.build-test-results-tab
> >
> > Could you please have a look? I suspect that this has something to do with
> > those new tests needing the `FUNNYNAMES` prereq.
>
> I need this commit to fix it:
> https://github.com/git-for-windows/git/commit/7ca815e1ab89d6ffdb1a17b3cbacdf22a508d33c
>
> I'll paste it here, for your convenience:
>
> -- snipsnap --
Thanks for reporting and correcting the testing issue. I'll send a v2
with your patch squashed in.
next prev parent reply other threads:[~2020-04-19 6:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 21:55 git-grep's "-z" option misbehaves in subdirectory Greg Hurrell
2020-04-13 23:33 ` Junio C Hamano
2020-04-14 7:42 ` Matheus Tavares
2020-04-16 18:59 ` git-grep's "-z" option misbehaves in subdirectory Matheus Tavares Bernardino
2020-04-16 20:07 ` Junio C Hamano
2020-04-17 6:04 ` [PATCH] grep: follow conventions for printing paths w/ unusual chars Matheus Tavares
2020-04-17 6:45 ` Junio C Hamano
2020-04-17 21:19 ` Matheus Tavares Bernardino
2020-04-17 21:35 ` Junio C Hamano
2020-04-18 13:13 ` Johannes Schindelin
2020-04-18 14:56 ` Johannes Schindelin
2020-04-19 6:27 ` Matheus Tavares Bernardino [this message]
2020-04-19 6:33 ` [PATCH v2] " Matheus Tavares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHd-oW4dkLMp3FYyRoRWVgcTMJ0oKnKfnK--3r_Mx9EfrLoEnQ@mail.gmail.com \
--to=matheus.bernardino@usp.br \
--cc=Johannes.Schindelin@gmx.de \
--cc=asheiduk@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=greg@hurrell.net \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).